Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat expire not required documents #357

Closed
wants to merge 16 commits into from

Conversation

santostiago
Copy link
Contributor

Task.

This PR adds "not-required" documents to the list of documents to expire.

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Check the commit's or even all commits' message styles matches our requested structure.
  • Check your code additions will fail neither code linting checks nor unit test.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Only valid documents get expired

Issue Number: 183467740

What is the new behavior?

Not required documents also get expired.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@santostiago
Copy link
Contributor Author

Going to do it again because the base branch was master instead of develop.

@santostiago santostiago closed this Nov 6, 2022
@tsubik tsubik deleted the feat-expire_not_required_documents branch January 5, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants