Change sorting column in admin panel to prevent server crash #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santostiago
approved these changes
Oct 20, 2022
|
I'll also check the timeouts for AR and the DB |
|
I think that might be something with Postgres (like using old version), because it just takes all CPU for those queries after couple seconds and system freezes. |
…s there is no limit in query and returns whole dataset and that is too much
tsubik
force-pushed
the
hot-fix/sorting-columns
branch
from
ef641f4
to
6ef97d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that this is because the old version of active admin which uses old version of ransack. When sorting by for example countries_translations.name in operator LIMIT and OFFSET is removed from query what is causing the whole dataset to load.