Chore/more cleanup and housekeeping #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tsubik
commented
Jul 23, 2022
•
tsubik
commented
- updating gems just conservative update for now
- removing not needed gems
- fix DB queries when loading active admin application code, filter's collection should be proc if it makes db query or is dynamic
- upgrade ruby version
- low-hanging fruit of extra specs for admin panel (bringing up code coverage from 63% to 77%)
tsubik
force-pushed
the
chore/more-cleanup
branch
from
84ef0fa
to
74e82f4
Compare
|
I decided to remove all depredations in this PR as well. |
|
Or actually no, first we need to add couple more specs to bring up coverage to at least 80, 85% |
santostiago
approved these changes
Jul 28, 2022
| @@ -65,7 +62,7 @@ | |||
| column :operator_document_created_at | |||
| column :uploaded_by | |||
| column :attachment do |o| | |||
| o.attachment&.filename | |||
| o&.document_file&.attachment&.filename | |||
There was a problem hiding this comment.
No it was not, the csv was failing, looks like noone needed it.
| @@ -15,22 +16,34 @@ | |||
|
|
|||
| if resource.is_a?(ActiveAdmin::Page) || resource.defined_actions.include?(:index) | |||
| describe "GET index" do | |||
| it "returns http success" do | |||
| get :index | |||
| subject { get :index } | |||
| "attributes": {}, | ||
| "errors": { | ||
| "record": [ | ||
| "record with 100188 id is not exists" |
There was a problem hiding this comment.
I'm not sure why the English here is so bad...
There was a problem hiding this comment.
haha, I did not notice :D
| # because of the problem on CI that ogr2 returns dates in different formats | ||
| # and I'm not sure how to restrict format using that tool | ||
| # in that case I would just ignore those properties by treating them as dynamic ones | ||
| dynamic_attributes: %w[end_date last_updat start_date] |
There was a problem hiding this comment.
Suggested change
| dynamic_attributes: %w[end_date last_updat start_date] | |
| dynamic_attributes: %w[end_date last_update start_date] |
There was a problem hiding this comment.
that is the exact name of that date exported from shapefile ;] this is just to not error on wrong format as I described in the comment.
There was a problem hiding this comment.
Thanks for explanation :)
| expect(importer.results.as_json).to eq(JSON.parse(results)) | ||
|
|
||
| expect(importer.results.to_json).to match_snapshot("importers/observations_importer") | ||
| # expect(importer.results.as_json).to eq(JSON.parse(results)) |
There was a problem hiding this comment.
Forgot a comment line.
tsubik
force-pushed
the
chore/more-cleanup
branch
2 times, most recently
from
1862faf
to
7fdfd48
Compare
tsubik
force-pushed
the
chore/more-cleanup
branch
from
7fdfd48
to
02c7310
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.