Fix/update deployment tasks #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santostiago
reviewed
Jun 28, 2022
| end | ||
| command = "export PATH=\"/home/ubuntu/.rvm/gems/ruby-2.4.6/bin:/home/ubuntu/.rvm/gems/ruby-2.6.1@global/bin:/home/ubuntu/.rvm/rubies/ruby-2.6.1/bin:/home/ubuntu/bin:/home/ubuntu/.local/bin:/home/ubuntu/.nvm/versions/node/v10.9.0/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/home/ubuntu/.rvm/bin\"; cd ../../otp-observations-tool#{file_path}; npm install; npm run transifex:pull; npm run #{build_method}-build" | ||
| command = if Rails.env.staging? | ||
| "$HOME/otp-observations-tool-staging/script/deploy staging" |
There was a problem hiding this comment.
@tsubik why don't we run npm install and so on, anymore?
santostiago
approved these changes
Jun 28, 2022
|
Everything is in |
|
The same script is used now in post-receive hooks (I removed most of commands from those hooks, just leaving invocation of the script), just to have a single script wrapper for deployment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored deployment scripts for otp portal and observations tool. Here I'm refactoring and actually fixing deployments from the backoffice + small performance improvements.