-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[둘리] 3, 4단계 오목 제출합니다. #34
Merged
Merged
Changes from 1 commit
Commits
Show all changes
55 commits
Select commit
Hold shift + click to select a range
f4e19dd
rebase: step2
woowahan-pjs 1fea9a1
feat: set up the android project
woowahan-pjs ea810cb
feat: domain 이동
hyemdooly b8e4a8c
feat: add main activity and resources
woowahan-pjs 9d5a9ea
refactor(Omok, Controller): run 함수 삭제 및 컨트롤러로 이동
hyemdooly 2aeb6a6
feat(activity_main): TextView 추가
hyemdooly bfe2f72
feat(GameEventListener): GameEventListener 구현
hyemdooly 2fce9c1
refactor(Omok): 필요없는 주석 삭제
hyemdooly d9b8b7c
feat(Listener): 이벤트 리스너 구현 및 strings.xml에 string 정의
hyemdooly 3bf95f6
feat(MainActivity): MainActivity 구현
hyemdooly 3663712
refactor(Activity, Listener): 패키지 이동
hyemdooly 00b6655
refactor(Omok): endGame 함수 수정
hyemdooly bbc9fdd
refactor(OmokTest): OmokTest 테스트 재구현
hyemdooly dba7e4f
refactor(InputView, OutputView): InputView OutputView 인터페이스 삭제
hyemdooly 51d920c
refactor(TurnResult): TurnResult 생성, 점진적인 리팩터링
hyemdooly bcfeedb
refactor(MainActivity, PlayersTest): 필요없는 테스트 삭제, 도메인 변경에 따른 MainActi…
hyemdooly 15a1a7b
refactor(Players, Omok, Controller): Players 위치 Omok 안으로 변경, 안드로이드 Tu…
hyemdooly ebbbff4
refactor(MainActivity, GameEventListener): 버그 수정
hyemdooly 116de7b
refactor(OmokTest, PlayersTest): 리팩터링에 따른 테스트 수정
hyemdooly 7308130
feat(MainActivity, Omok, OmokConstract, OmokDBHelper, Players): 데이터베이…
hyemdooly 8776916
refactor(gitignore): gitignore 추가
hyemdooly a11e464
feat(DBManager): DB로부터 원하는 정보를 뽑아주는 DBManager 생성
hyemdooly ff54862
refactor(MainActivity): 메인 액티비티 리팩터링
hyemdooly 9c68fba
refactor(OmokDBManager): 필요없는 코드 삭제
hyemdooly 0bde83d
refactor(xml): 오목판 커스텀
hyemdooly 66200e5
refactor(MainActivity): 오목판 세팅 함수 분리
hyemdooly 8bedfaa
refactor(MainActivity): 필요없는 코드 삭제
hyemdooly c753b65
fix(WhitePlayerTest): 테스트 코드 수정
hyemdooly 5b456b2
Merge branch 'hyemdooly' into step4
hyemdooly 4508479
refactor(xml): 필요없는 파일 삭제
hyemdooly b0a5e0f
refactor(Players, Player): 놓은 돌의 개수를 반환하는 함수 작성
hyemdooly 31d1f8a
refactor(PlayerState): points 변수 protected 삭제
hyemdooly 774c598
refactor(PlayerState): points 변수 protected 복구, getAllPoints 깊은 복사
hyemdooly a52748f
refactor(Black,WhitePlayerTest): 필요없는 정보 숨기기
hyemdooly e760a35
refactor(Points): Point List 깊은 복사
hyemdooly 1c6b39f
refactor(PlayersTest): 테스트 코드 수정
hyemdooly 3c0c212
refactor(MainActivity): 코드 다이어트 및 by lazy 적용
hyemdooly e8a7478
refactor(all): ktlintFormatting
hyemdooly bc554db
refactor(Players): latestPlayer 불변으로 변경
hyemdooly 9d15441
refactor(Players, WhitePlayer, BlackPlayer): stone -> point로 명칭 변경, 최…
hyemdooly 2d9db1e
refactor(OmokGameEventListener): InputView의 인터페이스 삭제, GameEventListen…
hyemdooly 19e46b5
fix(BlackPlayer, WhitePlayer): 오류 수정
hyemdooly 2aab2ac
refactor(TurnResult): 턴의 결과를 모두 포함하도록 수정
hyemdooly 160abef
refactor(Omok): 필요없는 함수 삭제
hyemdooly 355405a
refactor(MainActivity, TurnEventListener): 도메인 변경에 따른 코드 변경
hyemdooly e602dd4
refactor(Players, MainActivity): 필요없는 코드 삭제, 변수 네이밍 변경
hyemdooly 3178d22
refactor(MainActivity, Controller, DBHelper, OutputView): 리스너, DB매니저 …
hyemdooly ccb0c20
refactor(ktlintFormat): ktlintformatting
hyemdooly b0e1fa1
refactor(DBHelper): db를 변수로 가지도록 변경
hyemdooly fd3b14b
refactor(Players): Players 팩토리 함수 생성
hyemdooly 6d1ac8b
refactor(MainActivity): applicationContext -> this 변경
hyemdooly 343d2fe
refactor(MainActivity): 많은 if문 when문 사용하여 정리
hyemdooly 14ad02c
refactor(PlayersTest): 팩토리 함수 구현으로 인한 변경
hyemdooly d347785
refactor(OmokDBHelper): 오목 도메인을 가질 수 있도록 수정
hyemdooly 98d9be3
refactor(MainActivity): onCreate에서 onClickListener 내용 분리
hyemdooly File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
refactor(DBHelper): db를 변수로 가지도록 변경
- Loading branch information
commit b0e1fa1113b380d1c0af454e846aff81e36978b8
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DB 헬퍼를 raw값으로만 주고받도록 잘 만들어 주셨네요.
다만 이렇게 하게 되면 디비에 넣는 값이 변경되거나 스펙이 수정되면 코드를 외부에서 수정하는 상황이 생기기도 합니다.
이미 이름 자체가 오목 데이터베이스 헬퍼이기 때문에 오목에 대한 도메인을 가져도 된다고 생각합니다.