Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[둘리] 1, 2단계 오목 제출합니다. #26

Merged
merged 18 commits into from
Mar 17, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
fe3ce07
docs: 오목 기능 목록 작성
tmdgh1592 Mar 14, 2023
ca4182c
feat: 1부터 15 위치를 가진 오목알 클래스 구현
tmdgh1592 Mar 14, 2023
e13e7da
feat: 중복 오목알 처리를 위한 오목알 일급 컬렉션 구현
tmdgh1592 Mar 14, 2023
fa5e2b9
docs: .gitkeep 파일 제거
tmdgh1592 Mar 14, 2023
0c398fd
feat: 오목알을 놓은 플레이어가 게임에서 이겼는지 확인하는 기능 구현
tmdgh1592 Mar 14, 2023
190d007
feat: 사용자가 오목알을 놓았을 때 상태를 반환하는 기능 구현
tmdgh1592 Mar 14, 2023
9d0c276
feat: 오목판에 돌을 올려놓는 기능 구현
tmdgh1592 Mar 15, 2023
606cfcf
feat: 플레이어의 오목알을 놓는 턴을 바꾸는 기능 구현
tmdgh1592 Mar 15, 2023
f96746e
refactor: 돌을 놓으면 새로운 상태를 가진 플레이어 반환하는 기능 구현
tmdgh1592 Mar 15, 2023
e5e8ce4
feat: 플레이어가 놓은 마지막 돌을 리턴하는 기능 구현
tmdgh1592 Mar 15, 2023
c472a31
refactor: 오목알을 놓을 수 있는지 확인하는 함수를 Players 클래스로 이동
tmdgh1592 Mar 15, 2023
f4f1b15
feat: 오목 게임 진행하는 기능 구현
tmdgh1592 Mar 15, 2023
28bb0cd
feat: 오목 게임 입력, 출력 화면 구현
tmdgh1592 Mar 15, 2023
f37f93b
feat: 오목 컨트롤러 구현
tmdgh1592 Mar 15, 2023
b1fcb5b
refactor: 도메인 패키지 분리
tmdgh1592 Mar 15, 2023
11b2666
fix: 중간에 오목알을 뒀을 때 승리 판정하지 않는 오류 수정
tmdgh1592 Mar 16, 2023
a0166e0
feat: 렌주룰 기능 추가 (미완성)
tmdgh1592 Mar 16, 2023
7eb0bc9
feat: 렌주룰 적용 (완성)
tmdgh1592 Mar 16, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: 도메인 패키지 분리
  • Loading branch information
tmdgh1592 committed Mar 15, 2023
commit b1fcb5bec46238b245fac02062ce0e596487fb07
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
import player.Player
import player.Players
package domain.board

import domain.player.Player
import domain.player.Players
import domain.stone.Stone
import domain.stone.StoneColor

class Board(private val players: Players) {
constructor(blackPlayer: Player, whitePlayer: Player) : this(Players(blackPlayer, whitePlayer))
Expand All @@ -14,9 +18,4 @@ class Board(private val players: Players) {
fun getPlayers(): Players = players.copy()

fun isRunning(): Boolean = players.isRunning

fun getWinner(): Player = players.getWinner()

// private fun makeEmptyBoard(): List<MutableList<BoardState>> =
// List(POSITION_RANGE.max()) { MutableList(POSITION_RANGE.max()) { BoardState.EMPTY } }
}
36 changes: 36 additions & 0 deletions src/main/kotlin/domain/game/Omok.kt
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
package domain.game

import domain.board.Board
import domain.player.BlackPlayer
import domain.player.WhitePlayer
import domain.stone.Stone
import domain.stone.StoneColor
import listener.OmokStartEndEventListener
import listener.OmokTurnEventListener

class Omok(
private val startEndEventListener: OmokStartEndEventListener,
private val turnEventListener: OmokTurnEventListener
) {
fun run() {
startEndEventListener.onStartGame()
var curStoneColor: StoneColor = StoneColor.BLACK
var curBoard = Board(BlackPlayer(), WhitePlayer())
do {
curBoard = takeTurn(curBoard, curStoneColor)
startEndEventListener.onEndTurn(curBoard.getPlayers())
curStoneColor = curStoneColor.next()
} while (curBoard.isRunning())
Comment on lines +21 to +25

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

가급적 do, while은 사용을 지양하는면 좋습니다.
while로 표현할 수는 없을까? 를 먼저 생각 해보세요.

조건을 마지막에 확인하기 때문에 코드를 읽는데 어려움이 있고 가독성을 낮춥니다.

var isRunning = curBoard.isRunning()
while (isRunning) {
   ...
   isRunning = curBoard.isRunning()
}

startEndEventListener.onEndGame(curStoneColor.next())
}

private fun takeTurn(board: Board, stoneColor: StoneColor): Board {
val newStone = Stone.of(turnEventListener.onTakeTurn(stoneColor))
val newBoard = board.putStone(stoneColor, newStone)
if (newBoard == null) {
turnEventListener.onNotPlaceable()
return takeTurn(board, stoneColor)
}
return newBoard
}
}
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package player
package domain.player

import Stone
import state.PlayerState
import state.PlayingState
import domain.state.PlayerState
import domain.state.PlayingState
import domain.stone.Stone

class BlackPlayer(state: PlayerState = PlayingState()) : Player(state) {
override fun putStone(stone: Stone): Player = BlackPlayer(state.add(stone))
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
package player
package domain.player

import Position
import Stone
import state.PlayerState
import state.WinState
import domain.position.Position
import domain.state.PlayerState
import domain.state.WinState
import domain.stone.Stone

abstract class Player(protected val state: PlayerState) : Cloneable {
val isWin: Boolean = state is WinState
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package player
package domain.player

import Stone
import StoneColor
import domain.stone.Stone
import domain.stone.StoneColor

data class Players private constructor(private val players: List<Player>) {
val isRunning: Boolean
Expand All @@ -20,7 +20,5 @@ data class Players private constructor(private val players: List<Player>) {

fun getWhitePlayer(): Player = players.first { it is WhitePlayer }

fun getWinner(): Player = players.first { it.isWin }

fun canPlace(stone: Stone): Boolean = players.none { it.isPlaced(stone) }
}
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package player
package domain.player

import Stone
import state.PlayerState
import state.PlayingState
import domain.state.PlayerState
import domain.state.PlayingState
import domain.stone.Stone

class WhitePlayer(state: PlayerState = PlayingState()) : Player(state) {
override fun putStone(stone: Stone): Player = WhitePlayer(state.add(stone))
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
package domain.position

data class Position(val row: Int, val col: Int) {
init {
require(row in POSITION_RANGE) { ROW_OUT_OF_RANGE_ERROR_MESSAGE }
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package state
package domain.state

import Position
import Stone
import Stones
import domain.position.Position
import domain.stone.Stone
import domain.stone.Stones

abstract class PlayerState(protected val stones: Stones = Stones()) {
abstract fun add(newStone: Stone): PlayerState
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package state
package domain.state

import Stone
import Stones
import domain.stone.Stone
import domain.stone.Stones

class PlayingState(stones: Stones = Stones()) : PlayerState(stones) {
override fun add(newStone: Stone): PlayerState {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package state
package domain.state

import Stone
import Stones
import domain.stone.Stone
import domain.stone.Stones

class WinState(stones: Stones) : PlayerState(stones) {
override fun add(newStone: Stone): PlayerState = this
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
import Position.Companion.POSITION_RANGE
package domain.stone

import domain.position.Position
import domain.position.Position.Companion.POSITION_RANGE

data class Stone private constructor(val position: Position) {
companion object {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
package domain.stone

enum class StoneColor {
BLACK, WHITE;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,11 @@
package domain.stone

import domain.position.Position

data class Stones(private val stones: List<Stone>) {
val lastStone: Stone
get() = stones.last().copy()

constructor(vararg stones: Stone) : this(stones.toList())

init {
Expand Down Expand Up @@ -31,15 +36,16 @@ data class Stones(private val stones: List<Stone>) {
val (startX, startY) = Pair(startPosition.row, startPosition.col)
var count = 1
var (currentX, currentY) = Pair(startX + direction.first * weight, startY + direction.second * weight)
while (currentX in Position.POSITION_RANGE && currentY in Position.POSITION_RANGE && hasStone(Stone.of(currentX, currentY))) {
while (inRange(currentX, currentY) && hasStone(Stone.of(currentX, currentY))) {
count++
currentX += direction.first * weight
currentY += direction.second * weight
}
if (count >= MINIMUM_WIN_CONDITION) return true
return false
return count >= MINIMUM_WIN_CONDITION
}

private fun inRange(x: Int, y: Int) = x in Position.POSITION_RANGE && y in Position.POSITION_RANGE

companion object {
private const val DUPLICATED_ERROR_MESSAGE = "중복되는 위치의 오목알을 가질 수 없습니다."
private const val MINIMUM_WIN_CONDITION = 5
Expand Down
30 changes: 0 additions & 30 deletions src/main/kotlin/game/Omok.kt

This file was deleted.

13 changes: 0 additions & 13 deletions src/main/kotlin/listener/OmokEventListener.kt

This file was deleted.

4 changes: 2 additions & 2 deletions src/main/kotlin/listener/OmokStartEndEventListener.kt
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
package listener

import domain.Position
import domain.StoneColor
import domain.player.Players
import domain.position.Position
import domain.stone.StoneColor

interface OmokStartEndEventListener {
fun onStartTurn(stoneColor: StoneColor, position: Position)
Expand Down
4 changes: 2 additions & 2 deletions src/main/kotlin/listener/OmokTurnEventListener.kt
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package listener

import domain.Position
import domain.StoneColor
import domain.position.Position
import domain.stone.StoneColor

interface OmokTurnEventListener {
fun onTakeTurn(stoneColor: StoneColor): Position
Expand Down
7 changes: 4 additions & 3 deletions src/main/kotlin/view/InputView.kt
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
package view

import domain.Position
import domain.Position.Companion.POSITION_RANGE
import domain.StoneColor
import domain.position.Position
import domain.position.Position.Companion.POSITION_RANGE
import domain.stone.StoneColor
import listener.OmokTurnEventListener
import view.model.BoardModel

class InputView : OmokTurnEventListener {
override fun onTakeTurn(stoneColor: StoneColor): Position = askPosition()
Expand Down
6 changes: 4 additions & 2 deletions src/main/kotlin/view/OutputView.kt
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
package view

import domain.Position
import domain.StoneColor
import domain.player.Players
import domain.position.Position
import domain.stone.StoneColor
import listener.OmokStartEndEventListener
import view.model.BoardModel
import view.model.ColorModel

class OutputView : OmokStartEndEventListener {
override fun onStartGame() {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package view
package view.model

import domain.Position
import domain.position.Position

object BoardModel {
private const val RANGE_MIN = 'A'
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package view
package view.model

import domain.StoneColor
import domain.stone.StoneColor

object ColorModel {
private const val BLACK = "흑"
Expand Down
7 changes: 4 additions & 3 deletions src/test/kotlin/BlackPlayerTest.kt
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import domain.player.BlackPlayer
import domain.player.Player
import domain.state.PlayingState
import domain.stone.Stones
import org.assertj.core.api.Assertions.assertThat
import org.junit.jupiter.api.Test
import player.BlackPlayer
import player.Player
import state.PlayingState

class BlackPlayerTest {
@Test
Expand Down
11 changes: 7 additions & 4 deletions src/test/kotlin/BoardTest.kt
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
import domain.board.Board
import domain.player.BlackPlayer
import domain.player.Player
import domain.player.WhitePlayer
import domain.state.PlayingState
import domain.stone.StoneColor
import domain.stone.Stones
import org.assertj.core.api.Assertions.assertThat
import org.junit.jupiter.api.Test
import player.BlackPlayer
import player.Player
import player.WhitePlayer
import state.PlayingState

class BoardTest {
@Test
Expand Down
2 changes: 2 additions & 0 deletions src/test/kotlin/Fixtures.kt
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import domain.stone.Stone

val ONE_ONE_STONE = Stone.of(1, 1)
val ONE_TWO_STONE = Stone.of(1, 2)
val ONE_THREE_STONE = Stone.of(1, 3)
Expand Down
4 changes: 2 additions & 2 deletions src/test/kotlin/OmokTest.kt
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import game.Omok

import org.junit.jupiter.api.Test

class OmokTest {
@Test
fun `한 플레이어라도 승리할 때까지 차례를 번갈아가면서 돌을 놓는다`() {
val omok = Omok()
// val omok = Omok()
}
}
5 changes: 3 additions & 2 deletions src/test/kotlin/PlayingStateTest.kt
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import domain.state.PlayingState
import domain.state.WinState
import domain.stone.Stones
import org.assertj.core.api.Assertions.assertThat
import org.junit.jupiter.api.Test
import state.PlayingState
import state.WinState

class PlayingStateTest {

Expand Down
1 change: 1 addition & 0 deletions src/test/kotlin/PositionTest.kt
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import domain.position.Position
import org.assertj.core.api.Assertions.assertThat
import org.junit.jupiter.api.Test
import org.junit.jupiter.api.assertAll
Expand Down
1 change: 1 addition & 0 deletions src/test/kotlin/StoneColorTest.kt
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import domain.stone.StoneColor
import org.assertj.core.api.Assertions.assertThat
import org.junit.jupiter.params.ParameterizedTest
import org.junit.jupiter.params.provider.CsvSource
Expand Down
2 changes: 1 addition & 1 deletion src/test/kotlin/StoneTest.kt
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
class StoneTest {
// @Test
// fun `오목알은 자신의 위치를 알고 있다`() {
// val stone = Stone("H", 10)
// val stone = domain.stone.Stone("H", 10)
// assertThat(stone.x).isEqualTo("H")
// assertThat(stone.y).isEqualTo(10)
// }
Expand Down
Loading