Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[둘리] 뷰 챌린지 미션 2단계 제출합니다. #38

Merged
merged 28 commits into from
Oct 11, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
dc16a7d
feat: button bindingAdapter로 isSelected 생성
hyemdooly Oct 9, 2023
dee7ae1
feat: 선택된 버튼 색깔 생성
hyemdooly Oct 9, 2023
74f09cb
feat: 브러쉬 요소 추가
hyemdooly Oct 9, 2023
4e324fd
feat: 브러쉬 선택 기능 UI 추가
hyemdooly Oct 9, 2023
2e8ae10
feat: 함수 일부 네이밍 변경 및 Circle, Rectangle 그리기 기능 추가
hyemdooly Oct 9, 2023
4c813d6
refactor: 함수 분리 및 중복 코드 삭제
hyemdooly Oct 9, 2023
c56475f
feat: 지우개 기능 구현
hyemdooly Oct 9, 2023
dc53032
refactor: Drawing 클래스에서 Path, Paint 복사하도록 수정
hyemdooly Oct 9, 2023
7da23af
feat: 전체 삭제, undo, redo 구현
hyemdooly Oct 9, 2023
e22dfd6
refactor: 함수 순서 수정
hyemdooly Oct 9, 2023
87daa31
refactor: SettingState sealed class -> enum class로 변경, 상수 위치 이동
hyemdooly Oct 9, 2023
0b210df
refactor: width로 굵기 네이밍 통일
hyemdooly Oct 9, 2023
943e72c
refactor: Brush -> Tool로 네이밍 변경
hyemdooly Oct 10, 2023
1cf3673
refactor: enum class 상수 네이밍 변경
hyemdooly Oct 10, 2023
316933e
refactor: Drawing 클래스 세분화
hyemdooly Oct 10, 2023
2d10fa3
refactor: tool이 drawing 객체를 리턴하도록 수정
hyemdooly Oct 10, 2023
f67b8ac
refactor: CanvasView가 하던 일을 Drawing 클래스로 이동
hyemdooly Oct 11, 2023
ee553e0
refactor: undo, redo 코드 줄 수 줄이기
hyemdooly Oct 11, 2023
cd6ff78
design: 도구에 따른 설정 화면 변경
hyemdooly Oct 11, 2023
dd8e201
refactor: 도구에 따라 버튼 동적 생성
hyemdooly Oct 11, 2023
26e18fe
refactor: brushes -> tools로 네이밍 수정
hyemdooly Oct 11, 2023
f412171
refactor: 함수명 수정
hyemdooly Oct 11, 2023
acb317f
refactor: tool 바꿀 때 설정창 닫도록 수정
hyemdooly Oct 11, 2023
f55275e
fix: Rectangle 버그 수정
hyemdooly Oct 11, 2023
b10fda7
refactor: 도구 모음 일치
hyemdooly Oct 11, 2023
d4a46c4
refactor: tool -> drawingTool로 네이밍 변경
hyemdooly Oct 11, 2023
1d90521
refactor: Drawings 일급컬렉션 생성
hyemdooly Oct 11, 2023
1264668
refactor: 팩토리 함수 삭제
hyemdooly Oct 11, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: tool -> drawingTool로 네이밍 변경
  • Loading branch information
hyemdooly committed Oct 11, 2023
commit d4a46c47c8b82c75b9170fb40590b080ffdda146
12 changes: 6 additions & 6 deletions app/src/main/java/woowacourse/paint/MainActivity.kt
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import android.os.Bundle
import androidx.activity.viewModels
import androidx.appcompat.app.AppCompatActivity
import com.google.android.material.slider.RangeSlider
import woowacourse.paint.canvas.Tool
import woowacourse.paint.canvas.DrawingTool
import woowacourse.paint.databinding.ActivityMainBinding
import woowacourse.paint.databinding.ItemToolBinding
import woowacourse.paint.utils.toUiModel
Expand Down Expand Up @@ -46,15 +46,15 @@ class MainActivity : AppCompatActivity() {
adapter.submitList(colors)
}
}
viewModel.selectedTool.observe(this) { tool ->
viewModel.selectedDrawingTool.observe(this) { tool ->
canvasView.setupTools(tool)
changeButtonSelectedStatus(tool)
}
}

private fun changeButtonSelectedStatus(tool: Tool) {
private fun changeButtonSelectedStatus(drawingTool: DrawingTool) {
toolButtons.forEach { button ->
button.root.isSelected = button.tool == tool
button.root.isSelected = button.drawingTool == drawingTool
}
viewModel.setSettingState(PaintChangingState.NOTHING)
}
Expand All @@ -73,11 +73,11 @@ class MainActivity : AppCompatActivity() {
}

private fun setupTools() {
viewModel.tools.forEach { toolAssigned ->
viewModel.drawingTools.forEach { toolAssigned ->
val toolButtonBinding = ItemToolBinding.inflate(layoutInflater, binding.llTools, true)
with(toolButtonBinding) {
onClick = viewModel::pickTool
tool = toolAssigned
drawingTool = toolAssigned
name = getString(toolAssigned.toUiModel().name)
}
toolButtons.add(toolButtonBinding)
Expand Down
12 changes: 6 additions & 6 deletions app/src/main/java/woowacourse/paint/MainViewModel.kt
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ import androidx.lifecycle.LiveData
import androidx.lifecycle.MutableLiveData
import androidx.lifecycle.Transformations
import androidx.lifecycle.ViewModel
import woowacourse.paint.canvas.DrawingTool
import woowacourse.paint.canvas.PaletteColor
import woowacourse.paint.canvas.Tool
import woowacourse.paint.model.ColorUiModel

class MainViewModel : ViewModel() {
Expand All @@ -19,10 +19,10 @@ class MainViewModel : ViewModel() {
val colors: LiveData<List<ColorUiModel>>
get() = _colors

val tools = Tool.values().toList()
val drawingTools = DrawingTool.values().toList()

private var _selectedTool = MutableLiveData(tools.first())
val selectedTool: LiveData<Tool>
private var _selectedTool = MutableLiveData(drawingTools.first())
val selectedDrawingTool: LiveData<DrawingTool>
get() = _selectedTool

val selectedColor: LiveData<PaletteColor>
Expand All @@ -42,8 +42,8 @@ class MainViewModel : ViewModel() {
_paintChangingState.value = state
}

fun pickTool(tool: Tool) {
_selectedTool.value = tool
fun pickTool(drawingTool: DrawingTool) {
_selectedTool.value = drawingTool
}

fun pickColor(model: ColorUiModel) {
Expand Down
12 changes: 6 additions & 6 deletions app/src/main/java/woowacourse/paint/canvas/CanvasView.kt
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@ class CanvasView(context: Context, attr: AttributeSet) : View(
context,
attr,
) {
private var tool = Tool.PEN
private var drawingTool = DrawingTool.PEN
private val paint = Paint().apply {
isAntiAlias = true
style = Paint.Style.FILL_AND_STROKE
strokeCap = Paint.Cap.ROUND
xfermode = if (tool == Tool.ERASER) {
xfermode = if (drawingTool == DrawingTool.ERASER) {
PorterDuffXfermode(PorterDuff.Mode.CLEAR)
} else {
null
Expand Down Expand Up @@ -49,7 +49,7 @@ class CanvasView(context: Context, attr: AttributeSet) : View(
when (event.action) {
MotionEvent.ACTION_DOWN -> {
drawingsCanceled.clear()
drawings.add(tool.draw(paint, ::invalidate))
drawings.add(drawingTool.draw(paint, ::invalidate))
drawings.last().onTouchEvent(event)
}

Expand All @@ -64,9 +64,9 @@ class CanvasView(context: Context, attr: AttributeSet) : View(
return true
}

fun setupTools(selectedTool: Tool) {
tool = selectedTool
if (tool == Tool.ERASER) {
fun setupTools(selectedDrawingTool: DrawingTool) {
drawingTool = selectedDrawingTool
if (drawingTool == DrawingTool.ERASER) {
paint.xfermode = PorterDuffXfermode(PorterDuff.Mode.CLEAR)
return
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import woowacourse.paint.canvas.drawing.Drawing
import woowacourse.paint.canvas.drawing.Line
import woowacourse.paint.canvas.drawing.Rectangle

enum class Tool(val hasWidth: Boolean, val hasColor: Boolean) {
enum class DrawingTool(val hasWidth: Boolean, val hasColor: Boolean) {
PEN(true, true) {
override fun draw(paint: Paint, invalidate: () -> Unit): Drawing =
Line.of(paint, invalidate)
Expand Down
12 changes: 6 additions & 6 deletions app/src/main/java/woowacourse/paint/utils/ToolMapper.kt
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
package woowacourse.paint.utils

import woowacourse.paint.R
import woowacourse.paint.canvas.Tool
import woowacourse.paint.canvas.DrawingTool
import woowacourse.paint.model.ToolUiModel

fun Tool.toUiModel(): ToolUiModel {
fun DrawingTool.toUiModel(): ToolUiModel {
return when (this) {
Tool.PEN -> ToolUiModel(R.string.pen)
Tool.RECTANGLE -> ToolUiModel(R.string.rectangle)
Tool.CIRCLE -> ToolUiModel(R.string.circle)
Tool.ERASER -> ToolUiModel(R.string.eraser)
DrawingTool.PEN -> ToolUiModel(R.string.pen)
DrawingTool.RECTANGLE -> ToolUiModel(R.string.rectangle)
DrawingTool.CIRCLE -> ToolUiModel(R.string.circle)
DrawingTool.ERASER -> ToolUiModel(R.string.eraser)
}
}
10 changes: 5 additions & 5 deletions app/src/main/res/layout/activity_main.xml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

<import type="woowacourse.paint.PaintChangingState" />

<import type="woowacourse.paint.canvas.Tool" />
<import type="woowacourse.paint.canvas.DrawingTool" />

<import type="android.view.View" />
</data>
Expand Down Expand Up @@ -72,7 +72,7 @@
android:id="@+id/rs_width_changer"
android:layout_width="0dp"
android:layout_height="wrap_content"
android:visibility="@{viewModel.paintChangingState == PaintChangingState.WIDTH_CHANGING &amp;&amp; viewModel.selectedTool.hasWidth ? View.VISIBLE : View.GONE}"
android:visibility="@{viewModel.paintChangingState == PaintChangingState.WIDTH_CHANGING &amp;&amp; viewModel.selectedDrawingTool.hasWidth ? View.VISIBLE : View.GONE}"
app:layout_constraintBottom_toTopOf="@id/btn_change_width"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent" />
Expand All @@ -82,7 +82,7 @@
android:layout_width="0dp"
android:layout_height="wrap_content"
android:orientation="horizontal"
android:visibility="@{viewModel.paintChangingState == PaintChangingState.COLOR_CHANGING &amp;&amp; viewModel.selectedTool.hasColor ? View.VISIBLE : View.GONE}"
android:visibility="@{viewModel.paintChangingState == PaintChangingState.COLOR_CHANGING &amp;&amp; viewModel.selectedDrawingTool.hasColor ? View.VISIBLE : View.GONE}"
app:layoutManager="androidx.recyclerview.widget.LinearLayoutManager"
app:layout_constraintBottom_toTopOf="@id/btn_change_color"
app:layout_constraintEnd_toEndOf="parent"
Expand All @@ -96,7 +96,7 @@
android:layout_margin="5dp"
android:onClick="@{() -> viewModel.setSettingState(PaintChangingState.COLOR_CHANGING)}"
android:text="@string/main_change_color"
android:visibility="@{viewModel.selectedTool.hasColor ? View.VISIBLE : View.GONE}"
android:visibility="@{viewModel.selectedDrawingTool.hasColor ? View.VISIBLE : View.GONE}"
app:layout_constraintBottom_toTopOf="@id/ll_tools"
app:layout_constraintEnd_toStartOf="@id/btn_change_width"
app:layout_constraintStart_toStartOf="parent" />
Expand All @@ -108,7 +108,7 @@
android:layout_margin="5dp"
android:onClick="@{() -> viewModel.setSettingState(PaintChangingState.WIDTH_CHANGING)}"
android:text="@string/main_change_thickness"
android:visibility="@{viewModel.selectedTool.hasWidth ? View.VISIBLE : View.GONE}"
android:visibility="@{viewModel.selectedDrawingTool.hasWidth ? View.VISIBLE : View.GONE}"
app:layout_constraintBottom_toTopOf="@id/ll_tools"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toEndOf="@id/btn_change_color" />
Expand Down
6 changes: 3 additions & 3 deletions app/src/main/res/layout/item_tool.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@

<data>
<variable
name="tool"
type="woowacourse.paint.canvas.Tool" />
name="drawingTool"
type="woowacourse.paint.canvas.DrawingTool" />

<variable
name="name"
Expand All @@ -21,6 +21,6 @@
android:layout_height="wrap_content"
android:layout_margin="5dp"
android:backgroundTint="@color/brush_selected"
android:onClick="@{() -> onClick.invoke(tool)}"
android:onClick="@{() -> onClick.invoke(drawingTool)}"
android:text="@{name}" />
</layout>