-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[둘리] 뷰 챌린지 미션 2단계 제출합니다. #38
Merged
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
dc16a7d
feat: button bindingAdapter로 isSelected 생성
hyemdooly dee7ae1
feat: 선택된 버튼 색깔 생성
hyemdooly 74f09cb
feat: 브러쉬 요소 추가
hyemdooly 4e324fd
feat: 브러쉬 선택 기능 UI 추가
hyemdooly 2e8ae10
feat: 함수 일부 네이밍 변경 및 Circle, Rectangle 그리기 기능 추가
hyemdooly 4c813d6
refactor: 함수 분리 및 중복 코드 삭제
hyemdooly c56475f
feat: 지우개 기능 구현
hyemdooly dc53032
refactor: Drawing 클래스에서 Path, Paint 복사하도록 수정
hyemdooly 7da23af
feat: 전체 삭제, undo, redo 구현
hyemdooly e22dfd6
refactor: 함수 순서 수정
hyemdooly 87daa31
refactor: SettingState sealed class -> enum class로 변경, 상수 위치 이동
hyemdooly 0b210df
refactor: width로 굵기 네이밍 통일
hyemdooly 943e72c
refactor: Brush -> Tool로 네이밍 변경
hyemdooly 1cf3673
refactor: enum class 상수 네이밍 변경
hyemdooly 316933e
refactor: Drawing 클래스 세분화
hyemdooly 2d10fa3
refactor: tool이 drawing 객체를 리턴하도록 수정
hyemdooly f67b8ac
refactor: CanvasView가 하던 일을 Drawing 클래스로 이동
hyemdooly ee553e0
refactor: undo, redo 코드 줄 수 줄이기
hyemdooly cd6ff78
design: 도구에 따른 설정 화면 변경
hyemdooly dd8e201
refactor: 도구에 따라 버튼 동적 생성
hyemdooly 26e18fe
refactor: brushes -> tools로 네이밍 수정
hyemdooly f412171
refactor: 함수명 수정
hyemdooly acb317f
refactor: tool 바꿀 때 설정창 닫도록 수정
hyemdooly f55275e
fix: Rectangle 버그 수정
hyemdooly b10fda7
refactor: 도구 모음 일치
hyemdooly d4a46c4
refactor: tool -> drawingTool로 네이밍 변경
hyemdooly 1d90521
refactor: Drawings 일급컬렉션 생성
hyemdooly 1264668
refactor: 팩토리 함수 삭제
hyemdooly File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feat: 브러쉬 선택 기능 UI 추가
- Loading branch information
commit 4e324fd5843197c649fb6dca12d7b16852274640
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
.../java/woowacourse/paint/canvas/Brushes.kt → ...in/java/woowacourse/paint/canvas/Brush.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
package woowacourse.paint.canvas | ||
|
||
enum class Brushes { | ||
enum class Brush { | ||
PEN, RECTANGLE, CIRCLE, ERASER | ||
tmdgh1592 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
개인적으로
Brush
라는 단어를 들었을 때 붓이 연상되는데요!도형과 지우개는 브러시랑은 조금 거리가 있는 것처럼 느껴집니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tool로 수정했습니다~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이게 무슨
Tool
인지도 부가적인 설명이 있으면 좋겠네요~There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DrawingTool로 수정했습니다~