Fix endpoint response with immutable header #9876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 20106a5 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lilnasy
reviewed
Jan 30, 2024
1 task
ematipico
approved these changes
Jan 30, 2024
lilnasy
reviewed
Jan 30, 2024
lilnasy
approved these changes
Jan 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updated the implementation of
renderEndpointto only append the reroute header if the response has the HTTP status code 404 or 500.This should resolve the issue mentioned in #9871.
Testing
Added tests based on the work of @lilnasy (cad43ea5c11e58b022df82907cd110e56dd4efed).
These tests check that the response returned from an endpoint contains the expected headers and doesn't error with an HTTP 500 error.
Docs
I don't think there is a need to update the documentation because of this change, since it's only internal response rewriting.