Endpoint Response.redirect header modification

[friedemannsommer]

Astro Info

Astro                    v4.2.6
Node                     v20.11.0
System                   Linux (x64)
Package Manager          npm
Output                   server
Adapter                  @astrojs/node
Integrations             @astrojs/tailwind
                         @astrojs/react

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

When returning Response.redirect from an endpoint, the renderEndpoint function tries to set an HTTP response header on the Response object of the handler. This will throw a TypeError: immutable and return an HTTP 500 error to the client.

Note that new Response(..) and Response.json are not affected by this issue, even though they technically should be 🤔.

---

This is a relatively new change introduced by 075706f26d2e11e66ef8b52288d07e3c0fa97eb1.
These changes are included in Astro from version 4.2.4 and later.

What's the expected result?

The client should receive a HTTP 30X response with a Location header.

Link to Minimal Reproducible Example

https://stackblitz.com/edit/withastro-astro-2fktbw?file=README.md

Participation

• I am willing to submit a pull request for this issue.

[lilnasy]

Thanks for looking into it, this is all spot on!

I didn't know Response.redirect would have immutable headers, but it would make sense. The directive would have to be something other than a header.

[lilnasy]

I have written a test based on your repro here: main...lilnasy:astro:fix/9871

Feel free to take that and attempt a fix. I would guess putting the .set() in a try-catch block helps.