Re-enable streaming on Cloudflare Pages #5914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e27a812 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
natemoo-re
approved these changes
Jan 25, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, we disabled streaming on Cloudflare Pages because the Cloudflare Worker runtime didn't support ReadableStream (#3764, #3777). At the end of last year, the Worker Runtime was updated and now supports ReadableStream (Standards Compliant Workers API). So we can now remove the workarounds we had in place for Cloudflare.
Closes #5900.
Changes
Testing
I haven't added any tests - I couldn't see any examples of tests of streaming in other integrations.
I have deployed an example to Cloudflare Pages, available here: https://astro-streaming-cf.pages.dev/
The example is the basics example, except that the
<head>meta tags have an await in them for ~2 seconds. You can see in the waterfall that we stream the first part and then wait for 2 seconds:Docs
This brings the Cloudflare Pages integration back to the expected and documented streaming behaviour when SSR is enabled.