-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃悰 BUG: Streaming (1.0.0-beta.55) breaks Cloudflare Pages #3764
Comments
Notes from Triage Call
|
The I'm checking to see if there's anything we can use for feature detection, but it looks like we'll probably need to expose a flag to disable streaming |
Can the adapter not just buffer the response and create a new one with the final HTML? |
What version of
astro
are you using?1.0.0-beta.55
Are you using an SSR adapter? If so, which one?
Cloudflare
What package manager are you using?
pnpm
What operating system are you using?
mac
Describe the Bug
I'm super excited that streaming has landed in Astro, such a great feature!
Unfortunately Cloudflare Pages are currently stuck on a fairly old version of the workers runtime that doesn't support streams. There is as of right now no way to set the compatibility date or the flag to enable streams. I've asked about this again on the Cloudflare discord but the last update was "it's coming soon", which isn't a concrete timeframe.
What this means is that the Cloudflare adaptor, for now anyway, will only work with versions of Astro pre
1.0.0-beta.55
.I've tried the
web-streams polyfill
and buffering the response to a string in the Cloudflare adaptor but I think the issue lies in the fact that the Response constructor doesn't know what to do when passed a stream and just outputs[object ReadableStream]
.I don't think this is a bug or an issue with Astro, more Cloudflare Pages itself, but I've raised the issue here because I think it should be documented on the Cloudflare adaptor which I'm happy to raise a PR to do, since it's now somewhat broken. Or on the off chance there is a way to workaround the streams changes that went into Astro core?
Link to Minimal Reproducible Example
n/a
Participation
The text was updated successfully, but these errors were encountered: