Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix prettier arg #5263

Merged
merged 1 commit into from
Nov 1, 2022
Merged

ci: fix prettier arg #5263

merged 1 commit into from
Nov 1, 2022

Conversation

mrienstra
Copy link
Contributor

@mrienstra mrienstra commented Oct 31, 2022

Changes

  • pnpm run format --list
    • pnpm run format:code --list
      • prettier -w . --cache --plugin-search-dir=. --list
  • [warn] Ignored unknown option --list. <-- spotted in CI output
  • --list-different would work
  • --check outputs "a human-friendly message and a list of unformatted files, if any."
  • In this case, since we're not trying to do anything in particular with the output, might as well go for "human-friendly"
  • Originally added in fix failing format command in CI #2696

Testing, Docs

n/a

@changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2022

⚠️ No Changeset found

Latest commit: fd01691

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 🚨 action Modifies GitHub Actions label Oct 31, 2022
Copy link
Contributor

@jasikpark jasikpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bluwy bluwy merged commit 2f8c9a9 into withastro:main Nov 1, 2022
@mrienstra mrienstra deleted the patch-4 branch November 1, 2022 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 action Modifies GitHub Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants