Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix failing format command in CI #2696

Merged
merged 4 commits into from
Mar 1, 2022
Merged

Conversation

FredKSchott
Copy link
Member

@FredKSchott FredKSchott commented Mar 1, 2022

Changes

@changeset-bot
Copy link

changeset-bot bot commented Mar 1, 2022

⚠️ No Changeset found

Latest commit: 9295322

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 🚨 action Modifies GitHub Actions label Mar 1, 2022
@matthewp
Copy link
Contributor

matthewp commented Mar 1, 2022

@FredKSchott CI is failing for an odd reason, have any ideas?

@FredKSchott
Copy link
Member Author

This is the same issue that's been failing on main, the astro prettier plugin still seems to be having issues with the @astrojs/parser, but I have never been able to reproduce locally. Prettier config is pretty limited, and doesn't let you 100% disable plugin loading even with a few attempted hacky fixes.

@FredKSchott
Copy link
Member Author

Merging with an LGTM in Discord

@FredKSchott FredKSchott merged commit 9ec8980 into main Mar 1, 2022
@FredKSchott FredKSchott deleted the revert-failing-format-ci branch March 1, 2022 19:59
@mrienstra mrienstra mentioned this pull request Oct 31, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* fix failing format command in CI

* adds a check to formatting to ci

* ignore the prettier plugin for now

* update smoke to remove prettier plugin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 action Modifies GitHub Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants