Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix image integration README #4599

Merged
merged 4 commits into from
Sep 2, 2022
Merged

Fix image integration README #4599

merged 4 commits into from
Sep 2, 2022

Commits on Sep 2, 2022

  1. Wrap component tags in backticks 

    When the image integration README is pulled into the docs site, Astro tries to render <Image /> and <Picture /> which are then undefined, breaking the build. See withastro/docs#1457
    @delucis
    delucis committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    032580f View commit details
    Browse the repository at this point in the history

  2. Also wrap instances of alt="" in backticks

    @delucis
    delucis committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    27da41c View commit details
    Browse the repository at this point in the history

  3. Update packages/integrations/image/README.md 

    Co-authored-by: Sarah Rainsberger <[email protected]>
    @delucis @sarah11918
    delucis and sarah11918 committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    c12bd73 View commit details
    Browse the repository at this point in the history

  4. Also fix alt & add “e.g.” for <Picture /> section 

    Co-Authored-By: Sarah Rainsberger <[email protected]>
    @delucis @sarah11918
    delucis and sarah11918 committed Sep 2, 2022
    Configuration menu
    Copy the full SHA
    0dc2abd View commit details
    Browse the repository at this point in the history