Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image integration README #4599

Merged
merged 4 commits into from
Sep 2, 2022
Merged

Fix image integration README #4599

merged 4 commits into from
Sep 2, 2022

Conversation

delucis
Copy link
Member

@delucis delucis commented Sep 2, 2022

Changes

When the image integration README is pulled into the docs site, Astro tries to render <Image /> and <Picture /> which are then undefined, breaking the build. See withastro/docs#1457

I’ve also wrapped a few more snippets of code in backticks where it makes sense.

Testing

n/a

Docs

All docs, all the time 🕶️

When the image integration README is pulled into the docs site, Astro tries to render <Image /> and <Picture /> which are then undefined, breaking the build. See withastro/docs#1457
@changeset-bot
Copy link

changeset-bot bot commented Sep 2, 2022

⚠️ No Changeset found

Latest commit: 0dc2abd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Sep 2, 2022
@sarah11918
Copy link
Member

Woo! Thanks for catching my lack of backticks, @delucis 🙌 LGTM after changed in the other spot, too!

@delucis delucis merged commit eb4eebd into main Sep 2, 2022
@delucis delucis deleted the chris/fix-readme branch September 2, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants