Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix preact compat support for libraries #4213

Merged
merged 7 commits into from
Aug 10, 2022
Merged

Fix preact compat support for libraries #4213

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d453f97
Progress
matthewp Aug 4, 2022
06192ec
Merge branch 'main' into preact-compat-issue
bluwy Aug 9, 2022
00933db
Bump Vite
bluwy Aug 9, 2022
66cc924
Add test
bluwy Aug 9, 2022
8bbf89e
Pin Vite
bluwy Aug 9, 2022
605d422
Add changesets
bluwy Aug 9, 2022
ed5f91c
Merge branch 'main' into preact-compat-issue
bluwy Aug 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test
  • Loading branch information
@bluwy
bluwy committed Aug 9, 2022
commit 66cc9241c696c624395b5864ab265ab572d4d37c
7 changes: 7 additions & 0 deletions packages/astro/test/fixtures/preact-compat-component/astro.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
import { defineConfig } from 'astro/config';
import preact from '@astrojs/preact';

// https://astro.build/config
export default defineConfig({
integrations: [preact({ compat: true })],
});
11 changes: 11 additions & 0 deletions packages/astro/test/fixtures/preact-compat-component/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"name": "@test/preact-compat-component",
"version": "0.0.0",
"private": true,
"dependencies": {
"@astrojs/preact": "workspace:*",
"@test/react-lib": "workspace:*",
"astro": "workspace:*",
"preact": "^10.10.1"
}
}
5 changes: 5 additions & 0 deletions packages/astro/test/fixtures/preact-compat-component/packages/react-lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import { useState } from "react";

export function useSpecialState(initialState) {
return useState(initialState);
}
9 changes: 9 additions & 0 deletions packages/astro/test/fixtures/preact-compat-component/packages/react-lib/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"name": "@test/react-lib",
"version": "0.0.0",
"private": true,
"type": "module",
"dependencies": {
"react": "^18.2.0"
}
}
19 changes: 19 additions & 0 deletions packages/astro/test/fixtures/preact-compat-component/src/components/Counter.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
/** @jsxImportSource preact */
import { useSpecialState } from '@test/react-lib'

export default function Counter({ children }) {
const [count, setCount] = useSpecialState(0);
const add = () => setCount((i) => i + 1);
const subtract = () => setCount((i) => i - 1);

return (
<>
<div class="counter">
<button onClick={subtract}>-</button>
<pre id="counter-text">{count}</pre>
<button onClick={add}>+</button>
</div>
<div class="counter-message">{children}</div>
</>
);
}
12 changes: 12 additions & 0 deletions packages/astro/test/fixtures/preact-compat-component/src/pages/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
---
import Counter from '../components/Counter.jsx';
---

<html>
<head>
<title>Preact compat component</title>
</head>
<body>
<Counter client:load />
</body>
</html>
41 changes: 41 additions & 0 deletions packages/astro/test/preact-compat-component.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
import { expect } from 'chai';
import * as cheerio from 'cheerio';
import { loadFixture } from './test-utils.js';

describe('Preact compat component', () => {
describe('Development', () => {
let fixture;

before(async () => {
fixture = await loadFixture({
root: './fixtures/preact-compat-component/',
});
await fixture.startDevServer();
});

it('Can load Counter', async () => {
const html = await fixture.fetch('/').then((res) => res.text());
const $ = cheerio.load(html);

expect($('#counter-text').text()).to.be.eq('0');
});
});

describe('Build', () => {
let fixture;

before(async () => {
fixture = await loadFixture({
root: './fixtures/preact-compat-component/',
});
await fixture.build();
});

it('Can load Counter', async () => {
const html = await fixture.readFile('/index.html');
const $ = cheerio.load(html);

expect($('#counter-text').text()).to.be.eq('0');
});
});
});
43 changes: 18 additions & 25 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.