Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix preact compat support for libraries #4213

Merged
merged 7 commits into from
Aug 10, 2022
Merged

Fix preact compat support for libraries #4213

merged 7 commits into from
Aug 10, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Aug 9, 2022

Changes

Fix #4093
Fix #4107

Testing

Added preact-compat-component test fixture to astro/test, and a sub package @test/react-lib to emulate a React library to be using preact/compat instead.

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Aug 9, 2022

🦋 Changeset detected

Latest commit: ed5f91c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
astro Patch
@astrojs/preact Patch
@e2e/astro-component Patch
@e2e/error-react-spectrum Patch
@e2e/error-sass Patch
@e2e/errors Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: preact Related to Preact (scope) pkg: integration Related to any renderer integration (scope) labels Aug 9, 2022
@matthewp
Copy link
Contributor

matthewp commented Aug 9, 2022

Thanks @bluwy! We do want to continue to pin vite versions for a little while, so no ^.

Also needs a changeset.

@bluwy
Copy link
Member Author

bluwy commented Aug 9, 2022

My bad. Added changesets and pinned Vite to 3.0.5

Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're holding off on merging new PRs as 1.0 is coming out. Will approve after that is out and we're ready for merges again.

Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge now, thanks!

@bluwy bluwy merged commit f8e3853 into main Aug 10, 2022
@bluwy bluwy deleted the preact-compat-issue branch August 10, 2022 14:22
@astrobot-houston astrobot-houston mentioned this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: preact Related to Preact (scope)
Projects
None yet
3 participants