Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update error test for [email protected] #2877

Merged
merged 2 commits into from
Mar 24, 2022
Merged

test: update error test for [email protected] #2877

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed3112a
test: update error test for [email protected]
Mar 24, 2022
1330207
chore: add link to old tests
Mar 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 17 additions & 10 deletions packages/astro/test/errors.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { isWindows, loadFixture } from './test-utils.js';
import { expect } from 'chai';

describe('Error display', () => {
if (isWindows) return;
Expand All @@ -12,15 +13,21 @@ describe('Error display', () => {
});
});

describe('Astro', () => {
it('properly detect syntax errors in template', async () => {
try {
devServer = await fixture.startDevServer();
} catch (err) {
return;
}
await devServer.stop();
throw new Error('Expected to throw on startup');
});
describe('Astro', async () => {
// This test is skipped because it will hang on [email protected]
// TODO: unskip test once [email protected] lands
// See pre-integration system test: https://github.com/withastro/astro/blob/0f376a7c52d3a22ff32b33e0afc34dd306ed70c4/packages/astro/test/errors.test.js
it.skip('properly detect syntax errors in template', async () => {
try {
devServer = await fixture.startDevServer();
} catch (err) {
return;
}

// This is new behavior in [email protected], previously the server would throw on startup
const res = await fixture.fetch('/astro-syntax-error');
await devServer.stop();
expect(res.status).to.equal(500, `Successfully responded with 500 Error for invalid file`);
});
});
});