Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update error test for [email protected] #2877

Merged
merged 2 commits into from
Mar 24, 2022

Conversation

natemoo-re
Copy link
Member

Changes

  • Astro is now part of vite-ecosystem-ci. HOORAY! 馃帀
  • But... we're about to fail a test. BOO! 馃槶
  • This is due to a change in start-up behavior in [email protected]. Instead of failing to start the server because of a syntax error, Vite will start the server immediately and only fail when a malformed file is requested. HOORAY! 馃帀
  • This PR updates our test to account for the new Vite behavior, but skips the test until we're on the official [email protected] release.
  • This really doesn't change our coverage much, we were testing an implementation detail of Vite.

Testing

Test skip only

Docs

Test skip only, no docs needed

@changeset-bot
Copy link

changeset-bot bot commented Mar 24, 2022

鈿狅笍 No Changeset found

Latest commit: 1330207

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) test labels Mar 24, 2022
Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never been so excited to reduce test coverage 馃コ

@FredKSchott
Copy link
Member

funny enough, you might just be able to grab the test as it was written pre-integration system.

6386c14#diff-7eb8d1e475f3c51e2f4aa52b9089c5db80b4238c1539d0a9dfe23b0182a08d34

Maybe add that link to the comment over skip so that we don't lose track?

@natemoo-re natemoo-re merged commit a49f049 into main Mar 24, 2022
@natemoo-re natemoo-re deleted the chore/skip-throw-on-startup branch March 24, 2022 19:44
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* test: update error test for [email protected]

* chore: add link to old tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants