Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] update lockfile #2240

Merged
merged 3 commits into from
Dec 21, 2021
Merged

[ci] update lockfile #2240

merged 3 commits into from
Dec 21, 2021

Conversation

FredKSchott
Copy link
Member

This PR is auto-generated by a nightly GitHub action. It should automatically be merged if tests pass.

@changeset-bot
Copy link

changeset-bot bot commented Dec 20, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: bc17484

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jonathantneal
Copy link
Contributor

The error from CI / Build Packages is Property 'hot' does not exist on type 'ImportMeta'..

@FredKSchott
Copy link
Member Author

FredKSchott commented Dec 20, 2021 •
edited
Loading

oh wow I love this PR bot ❤️ looks like it's caused by either Node's types or Vite's patch release.

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Dec 21, 2021
@FredKSchott
Copy link
Member Author

Fixed the build issue: something changed in ImportMeta between vite 2.7.3->2.7.4. Since we're still vendoring Vite 2.6, it doesn't really make sense to use the 2.7 version in other places, so this PR fixes the issue by dropping our Vite version back down to v2.6.

@natemoo-re this will be something to tackle in your #1866 PR (sorry :)

@netlify
Copy link

netlify bot commented Dec 21, 2021 •
edited
Loading

✔️ Deploy Preview for astro-www ready!

🔨 Explore the source changes: bc17484

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-www/deploys/61c2158779251400075784c2

😎 Browse the preview: https://deploy-preview-2240--astro-www.netlify.app

@netlify
Copy link

netlify bot commented Dec 21, 2021

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: 4ed8149

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61c214f0aaf8fe0007e007ab

😎 Browse the preview: https://deploy-preview-2240--astro-docs-2.netlify.app

@netlify
Copy link

netlify bot commented Dec 21, 2021

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: bc17484

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61c21587cb19fc0007617e2a

😎 Browse the preview: https://deploy-preview-2240--astro-docs-2.netlify.app

@FredKSchott FredKSchott merged commit e07c1cb into main Dec 21, 2021
@FredKSchott FredKSchott deleted the create-pull-request/patch branch December 21, 2021 18:37
vineryap pushed a commit to vineryap/astro that referenced this pull request Dec 22, 2021
@FredKSchott @vineryap
[ci] update lockfile (withastro#2240)
58f9891 
* [ci] update lockfile

* fix package dependency issue

* Create heavy-pianos-obey.md

Co-authored-by: FredKSchott <[email protected]>
@github-actions github-actions bot mentioned this pull request Dec 22, 2021
Merged
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
@FredKSchott
[ci] update lockfile (withastro#2240)
79129e0 
* [ci] update lockfile

* fix package dependency issue

* Create heavy-pianos-obey.md

Co-authored-by: FredKSchott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FredKSchott @jonathantneal