Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to [email protected] #1866

Closed
wants to merge 46 commits into from
Closed

update to [email protected] #1866

wants to merge 46 commits into from

Conversation

FredKSchott
Copy link
Member

Changes

  • Update our Vite branch to latest v2.7
  • Useful for testing in this PR, and also may be worth merging for our own next release given the number of SSR fixes this version is reported to have

Testing

  • Still needs more before merging

@FredKSchott FredKSchott requested a review from a team as a code owner November 17, 2021 18:57
@changeset-bot
Copy link

changeset-bot bot commented Nov 17, 2021

🦋 Changeset detected

Latest commit: a0543a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 63 packages
Name Type
astro Patch
@astrojs/test-0-css Patch
@astrojs/test-astro-assets Patch
@astrojs/test-astro-attrs Patch
@astrojs/test-astro-basic Patch
@astrojs/test-astro-children Patch
@astrojs/test-astro-class-list Patch
@astrojs/test-astro-client-only Patch
@astrojs/test-astro-component-code Patch
@astrojs/test-astro-components Patch
@astrojs/test-astro-css-bundling-import Patch
@astrojs/test-astro-css-bundling-nested-layouts Patch
@astrojs/test-astro-css-bundling Patch
@astrojs/test-astro-doctype Patch
@astrojs/test-astro-dynamic Patch
@astrojs/test-astro-envs Patch
@astrojs/test-astro-expr Patch
@astrojs/test-astro-external-files Patch
@astrojs/test-astro-fallback Patch
@astrojs/test-astro-get-static-paths Patch
@astrojs/test-astro-global Patch
@astrojs/test-astro-jsx Patch
@astrojs/test-astro-markdown-plugins Patch
@astrojs/test-astro-markdown Patch
@astrojs/test-astro-page-directory-url Patch
@astrojs/test-astro-pages Patch
@astrojs/test-astro-pagination Patch
@astrojs/test-astro-partial-html Patch
@astrojs/test-astro-public Patch
@astrojs/test-astro-scripts Patch
@astrojs/test-astro-sitemap-rss Patch
@astrojs/test-astro-slots Patch
@astrojs/astro-test-builtins Patch
@astrojs/test-config-hostname Patch
@astrojs/test-config-path Patch
@astrojs/test-config-port Patch
@astrojs/test-custom-elements Patch
@astrojs/test-debug-component Patch
@astrojs/test-errors Patch
@astrojs/test-fetch Patch
@astrojs/test-lit-element Patch
@astrojs/test-markdown Patch
@astrojs/test-postcss Patch
@astrojs/test-preact-component Patch
@astrojs/test-react-component Patch
@astrojs/test-remote-css Patch
@astrojs/test-route-manifest Patch
@astrojs/test-sass Patch
@astrojs/test-slots-preact Patch
@astrojs/test-slots-react Patch
@astrojs/test-slots-solid Patch
@astrojs/test-slots-svelte Patch
@astrojs/test-slots-vue Patch
@astrojs/test-solid-component Patch
@astrojs/test-static-build-code-component Patch
@astrojs/test-static-build-frameworks Patch
@astrojs/test-static-build Patch
@astrojs/test-svelte-component Patch
@astrojs/test-vue-component Patch
@astrojs/test-with-subpath-no-trailing-slash Patch
@astrojs/test-with-subpath-trailing-slash Patch
@astrojs/test-without-site-config Patch
@astrojs/test-without-subpath Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Nov 17, 2021

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: 2316832

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61c4ee340e3f8300070a0876

😎 Browse the preview: https://deploy-preview-1866--astro-docs-2.netlify.app

@netlify
Copy link

netlify bot commented Nov 17, 2021

✔️ Deploy Preview for astro-www ready!

🔨 Explore the source changes: 2316832

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-www/deploys/61c4ee348f677300081a85bc

😎 Browse the preview: https://deploy-preview-1866--astro-www.netlify.app

@natemoo-re
Copy link
Member

Posted the first CI run to the Vite team to discuss.
https://discord.com/channels/804011606160703521/910615959922946148/910615961701326848

@FredKSchott FredKSchott marked this pull request as draft November 17, 2021 20:19
@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: vue Related to Vue (scope) pkg: integration Related to any renderer integration (scope) labels Nov 17, 2021
@FredKSchott FredKSchott marked this pull request as ready for review November 17, 2021 22:31
@drwpow
Copy link
Member

drwpow commented Nov 18, 2021

I think you’ll need to update astro/package.json’s vite dependency to match the built version as well

@github-actions github-actions bot added the pkg: svelte Related to Svelte (scope) label Dec 7, 2021
@natemoo-re natemoo-re self-assigned this Dec 7, 2021
@github-actions github-actions bot added pkg: solid Related to Solid (scope) test labels Dec 7, 2021
@natemoo-re natemoo-re changed the title update vendor/vite to 2.7 update to [email protected] Dec 7, 2021
@natemoo-re natemoo-re force-pushed the update-vite-2.7 branch 2 times, most recently from bcb4c1c to 084f9bf Compare December 13, 2021 21:08
@github-actions github-actions bot removed the pkg: svelte Related to Svelte (scope) label Dec 13, 2021
@natemoo-re
Copy link
Member

sveltejs/vite-plugin-svelte#225 should unblock most of the issues here!

@github-actions github-actions bot removed the pkg: solid Related to Solid (scope) label Jan 18, 2022
@github-actions github-actions bot added pkg: create-astro Related to the `create-astro` package (scope) docs feat: markdown Related to Markdown (scope) 🚨 action Modifies GitHub Actions labels Jan 18, 2022
@github-actions github-actions bot added pkg: lit Related to Lit (scope) pkg: preact Related to Preact (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) labels Jan 18, 2022
@natemoo-re natemoo-re marked this pull request as draft January 19, 2022 23:38
@natemoo-re
Copy link
Member

This PR has gotten extremely difficult to rebase. Closing in favor of #2424.

@natemoo-re natemoo-re closed this Jan 19, 2022
@bluwy bluwy deleted the update-vite-2.7 branch October 8, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 action Modifies GitHub Actions feat: markdown Related to Markdown (scope) pkg: astro Related to the core `astro` package (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: lit Related to Lit (scope) pkg: preact Related to Preact (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants