Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@astrojs/deno - "start" option is not typed as part of the adapter Options type. #8221

Closed
1 task
jaymanmdev opened this issue Aug 25, 2023 · 1 comment · Fixed by #8245
Closed
1 task
Assignees
Labels
- P1: chore Doesn't change code behavior (priority) help wanted Please help with this issue!

Comments

@jaymanmdev
Copy link

Astro info

N/A

What browser are you using?

N/A

Describe the Bug

When using the adapter, I get a typescript error stating that the property does not exist on the Options type for the adapter.

image

However, when I look further at the type declarations, the Option type only has the port and hostname options defined. The start option still works perfectly so it hasn't been taken out of the adapter (thankfully!), but it must have been overlooked when adjusting the adapter's type declaration.

image

What's the expected result?

N/A

Link to Minimal Reproducible Example

N/A

Participation

  • I am willing to submit a pull request for this issue.
@github-actions github-actions bot added the needs triage Issue needs to be triaged label Aug 25, 2023
@lilnasy lilnasy added help wanted Please help with this issue! - P1: chore Doesn't change code behavior (priority) and removed needs triage Issue needs to be triaged labels Aug 25, 2023
@florian-lefebvre
Copy link
Member

@lilnasy can you assign me? I'd like to handle this over the week-end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- P1: chore Doesn't change code behavior (priority) help wanted Please help with this issue!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants