fix(deno): add start to options interface and extract to new file (close

#8221) (#8245) * fix(deno): add start to options and extract to new file * Reword changeset --------- Co-authored-by: Arsh <[email protected]>
withastro · Aug 27, 2023 · ed39fbf · ed39fbf
1 parent cc740fb
commit ed39fbf
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 17 deletions.
diff --git a/.changeset/olive-moles-tan.md b/.changeset/olive-moles-tan.md
@@ -0,0 +1,5 @@
+---
+'@astrojs/deno': patch
+---
+
+TypeScript users now get better suggestions when configuring the Deno adapter.
diff --git a/packages/integrations/deno/src/index.ts b/packages/integrations/deno/src/index.ts
@@ -3,17 +3,7 @@ import esbuild from 'esbuild';
 import * as fs from 'node:fs';
 import * as npath from 'node:path';
 import { fileURLToPath } from 'node:url';
-
-interface BuildConfig {
- server: URL;
- serverEntry: string;
- assets: string;
-}
-
-interface Options {
- port?: number;
- hostname?: string;
-}
+import type { BuildConfig, Options } from './types';
 
 const SHIM = `globalThis.process = {
  argv: [],

diff --git a/packages/integrations/deno/src/server.ts b/packages/integrations/deno/src/server.ts
@@ -1,16 +1,11 @@
 // Normal Imports
 import type { SSRManifest } from 'astro';
 import { App } from 'astro/app';
+import type { Options } from './types';
 
 // @ts-expect-error
 import { fromFileUrl, serveFile, Server } from '@astrojs/deno/__deno_imports.js';
 
-interface Options {
- port?: number;
- hostname?: string;
- start?: boolean;
-}
-
 let _server: Server | undefined = undefined;
 let _startPromise: Promise<void> | undefined = undefined;
 

diff --git a/packages/integrations/deno/src/types.ts b/packages/integrations/deno/src/types.ts
@@ -0,0 +1,11 @@
+export interface Options {
+ port?: number;
+ hostname?: string;
+ start?: boolean;
+}
+
+export interface BuildConfig {
+ server: URL;
+ serverEntry: string;
+ assets: string;
+}