Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add path enumerable trait #155

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Add path enumerable trait #155

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cda7f10
Add path enumerable trait
bennothommo Aug 31, 2023
62411f8
Add getNested method and test
bennothommo Aug 31, 2023
5975793
Fix a couple of hard references to path column
bennothommo Aug 31, 2023
4af1e27
Merge branch 'develop' into wip/path-enumerable-trait
bennothommo Dec 11, 2023
1edb90e
Add ability to define a custom segment column.
bennothommo Dec 11, 2023
9e57356
Prevent forward-slashes in segment column from breaking hierarachy
bennothommo Dec 12, 2023
f27ded7
Fix comments
bennothommo Dec 12, 2023
7111f16
Merge remote-tracking branch 'origin/develop' into wip/path-enumerabl…
bennothommo Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix a couple of hard references to path column
  • Loading branch information
@bennothommo
bennothommo committed Aug 31, 2023
commit 5975793a4eee86b65e8d01254746018cd9825acc
4 changes: 2 additions & 2 deletions src/Database/Traits/PathEnumerable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ public function scopeAncestors(Builder $query): void
public function getEnumerablePath(): string
{
if ($this->parent()->exists()) {
return $this->parent->path . '/' . $this->id;
return $this->parent->{$this->getPathColumnName()} . '/' . $this->id;
}

return '/' . $this->id;
bennothommo marked this conversation as resolved.
Show resolved Hide resolved
Expand All @@ -188,7 +188,7 @@ public function getEnumerablePath(): string
*/
public function setEnumerablePath(): void
{
$this->path = $path = $this->getEnumerablePath();
$this->{$this->getPathColumnName()} = $path = $this->getEnumerablePath();

$this->newQuery()
->where($this->getKeyName(), $this->id)
Expand Down
Loading