Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add path enumerable trait #155

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Conversation

bennothommo
Copy link
Member

Implements path enumeration hierarchy for models, operating similar to nested set models but not requiring the rigid left/right values.

This is in preparation for some work towards database storage of media items.

Implements path enumeration hierarchy for models, operating similar to nested set models but not requiring the rigid left/right values.
@bennothommo bennothommo requested a review from a team September 23, 2023 12:57
Copy link

github-actions bot commented Dec 2, 2023

This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days.
If this is still being worked on, please respond and we will re-open this pull request.
If this pull request is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

@LukeTowers
Copy link
Member

@bennothommo 👀

This allows the path to be made up of segments from a different field, such as folder, or name. By default, path segments are derived from the primary key (usually an ID).
@LukeTowers
Copy link
Member

@bennothommo let me know when you want me to review this!

@bennothommo
Copy link
Member Author

@LukeTowers it's good to go :)

Copy link
Member

@LukeTowers LukeTowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @bennothommo, targeting next release pending docs PR for this feature :)

@LukeTowers LukeTowers added this to the 1.2.5 milestone Dec 27, 2023
@LukeTowers
Copy link
Member

@bennothommo is there a docs PR for this?

@bennothommo
Copy link
Member Author

@LukeTowers not yet - I'm toying with the idea of unifying the tree traits in some fashion so they share a common base level of functionality and API.

@LukeTowers
Copy link
Member

@bennothommo is that something that needs to happen now or could we move forward with merging this so that we can get metadata support added to the Media Library?

@bennothommo
Copy link
Member Author

@LukeTowers my concern is that we'll have difficulty changing the API later.

@mjauvin mjauvin modified the milestones: 1.2.5, 1.2.6 Feb 18, 2024
Copy link

This pull request will be closed and archived in 3 days, as there has been no activity in the last 60 days.
If this is still being worked on, please respond and we will re-open this pull request.
If this pull request is critical to your business, consider joining the Premium Support Program where a Service Level Agreement is offered.

@LukeTowers
Copy link
Member

@bennothommo status on this?

@LukeTowers LukeTowers modified the milestones: 1.2.6, 1.2.7 Apr 25, 2024
@bennothommo
Copy link
Member Author

Just waiting for docs. I mentioned previously trying to attempt to unify the tree APIs, but I probably won't do it for this branch. It might be worth looking into next major release.

@LukeTowers
Copy link
Member

@bennothommo sounds good to me, lets get the docs done up so we can roll this into the next release then. Would be nice to make some progress on the media library metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants