Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace QLC with plain ets:select/{1,3} #352

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

hauleth
Copy link
Contributor

@hauleth hauleth commented Aug 21, 2024

This should remove requirement for indirection that happen with QLC
process and should reduce need for additional data copy between QLC and
target process.

@hauleth
Copy link
Contributor Author

hauleth commented Aug 21, 2024

Does Cachix need to still support Elixir 1.7-1.9? These versions are long not supported.

@whitfin
Copy link
Owner

whitfin commented Aug 21, 2024

Hi @hauleth!

Yes, Cachex will continue to support v1.7+ (technically it supports back to v1.5 even!). In this case Function.identity/1 provides such minimal value that it's not worth changing the compatibility table for.

That being said this PR seems good (if that's updated) and I'm happy to merge and include in the next release!

This should remove requirement for indirection that happen with QLC
process and should reduce need for additional data copy between QLC and
target process.
@hauleth
Copy link
Contributor Author

hauleth commented Aug 21, 2024

@whitfin done. Also - I hope that you are hefty compensated for keeping that compatibility with so old Elixir releases.

@whitfin whitfin added this to the v4.0.0 milestone Aug 21, 2024
@whitfin whitfin self-assigned this Aug 21, 2024
@whitfin whitfin self-requested a review August 21, 2024 23:43
@whitfin
Copy link
Owner

whitfin commented Aug 22, 2024

Awesome, ty @hauleth - just so you know this is all good to go, I'm just holding on merging because I want to land this alongside a fix for #329 to remove all QLC in one sweep.

@whitfin whitfin merged commit 29221b5 into whitfin:main Aug 25, 2024
13 checks passed
@whitfin whitfin removed their request for review August 25, 2024 06:48
@hauleth hauleth deleted the refactor/stream branch September 30, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants