Strip out :qlc from LRW implementation #354
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #329. Rather than fix the issue with
:qlc
, I figured it might just be best to avoid it directly.Instead we now use
Cachex.stream/2
for the LRW policy, which under the hood now uses:ets.select/3
thanks to #352. This means the implementation is now much easier to understand, and is just built on top of other Cachex structures. I'm not sure if there's a performance hit, my benchmarking was inconclusive (although there's a chance it's faster, even?).I also took the opportunity to rename
Cachex.Query.create/2
toCachex.Query.where/2
as this now reads a bit better (even if it could still be improved):