Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for service principal authentication #77

Merged
merged 4 commits into from
Mar 31, 2024
Merged

Add support for service principal authentication #77

merged 4 commits into from
Mar 31, 2024

Conversation

moredatapls
Copy link
Contributor

@moredatapls moredatapls commented Feb 25, 2024 •
edited
Loading

Fixes #71

  • Add support for Service Principal authentication
  • Deduplicate some code in the AzureDevopsClient
  • Add logging and improved error handling to the AzureDevopsClient

@moredatapls moredatapls changed the title Add support for service principal authentication [WIP] Add support for service principal authentication Mar 4, 2024
@moredatapls
Copy link
Contributor Author

@nevembalint thank you for the approval but I haven't fully tested the changes yet :) will let you know when it's ready to be reviewed

@moredatapls moredatapls marked this pull request as ready for review March 4, 2024 22:56
@moredatapls moredatapls changed the title [WIP] Add support for service principal authentication Add support for service principal authentication Mar 4, 2024
@balcsida
Copy link

balcsida commented Mar 5, 2024

Sorry to ping you directly, @mblaschke, but if you have the chance, could you please check this matter out?

balcsida
balcsida suggested changes Mar 5, 2024
View reviewed changes
.vscode/launch.json Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@mblaschke mblaschke merged commit 9c9b703 into webdevops:main Mar 31, 2024
3 checks passed
@moredatapls moredatapls deleted the add-sp-authentication branch April 16, 2024 07:07
@moredatapls moredatapls mentioned this pull request Jun 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balcsida balcsida balcsida requested changes

@nevembalint nevembalint nevembalint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Service Principal / Managed Identity auth instead of PAT?
4 participants
@moredatapls @balcsida @nevembalint @mblaschke