Fix an issue where the resty clients weren't initialized correctly #89
Conversation
|
|
Any chance that this can be reviewed and merged soon-ish @mblaschke? It would help us greatly :) Thank you for your efforts |
|
| if *restClient == nil { | ||
| *restClient = c.restWithoutToken(domain) | ||
| func (c *AzureDevopsClient) restWithAuthentication(restClient *resty.Client, domain string) (*resty.Client, error) { | ||
| if restClient == nil { |
There was a problem hiding this comment.
@mblaschke I see that you removed the double pointer I added here. I added this on purpose: assigning a value to restClient here will not update c.restClient that gets passed into this function. To make this work, I added the double pointer, so that I can actually update the c.restClient field.
Therefore, the client will not get cached in the devops client object (c.restClient will always be nil), if restClient == nil statement will always evaluate to true, and the client will always get reinitialized.
The
restWithAuthenticationfunction always only usedc.restClient, even if ac.restClientVsrmwas requested.Fix it by passing pointers to the respective function.
Fixes #86
I tested the changes locally against our DevOps instance and I didn't see the 404 errors anymore