-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It doesn't work now, some corrections needed #26
Comments
Since the and we do check whether input is hex encoded string. I don't figure out why we should check nullable |
If you are passing array, not hexstring, here: https://github.com/web3p/ethereum-tx/blob/master/src/Transaction.php#L176, your $tx variable doesn't exists after IFs. Your code is not working in that case at all, failing with assignment to nothing. There are numerous methods to solve it, including involving more experienced programmers, of course. Just no-testing-error :) |
Oh, I see! I didn't set the default value of $txData. |
You need to add check for nullable $tx in __construct where $this->txData = $tx.
I.e.:
The text was updated successfully, but these errors were encountered: