Merge pull request #29 from sc0Vu/fix-26

Fix #26
web3p · Sep 21, 2020 · 5ae9729 · 5ae9729
2 parents e2f3461 + 8d2584e
commit 5ae9729
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/src/Transaction.php b/src/Transaction.php
@@ -131,7 +131,7 @@ class Transaction implements ArrayAccess
  * 
  * @var array
  */
- protected $txData;
+ protected $txData = [];
 
  /**
  * RLP encoding instance

diff --git a/test/unit/TransactionTest.php b/test/unit/TransactionTest.php
@@ -318,4 +318,21 @@ public function testIssue15()
  $this->assertEquals($signedTransactions[0], $signedTransactions[$i]);
  }
  }
+
+ /**
+ * testIssue26
+ * default $txData should be empty array
+ * 
+ * @return void
+ */
+ public function testIssue26()
+ {
+ $tests = [
+ null, [], [null]
+ ];
+ for ($i=0; $i<count($tests); $i++) {
+ $transaction = new Transaction($tests[i]);
+ $this->assertEquals($transaction->txData, []);
+ }
+ }
 }