This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Fix in-container device nodes for containerd runtime #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stealthybox
force-pushed
the
ctrd-devpath-fix
branch
from
ee06a79
to
44a8d6a
Compare
stealthybox
added
area/runtime
darkowlzz
approved these changes
Aug 9, 2020
There was a problem hiding this comment.
Tested it manually and it works great.
The test fails for docker+docker-bridge on CI consistently. But I couldn't reproduce it running it on my machine. It fails when stopping the VM. The test works fine without stopping the first VM, the file is accessible from the second VM. Maybe we can avoid the VM stop for now and deal with the stop issue separately.
e2e/run_volume_test.go
Outdated
| // | ||
| // This is the e2e package to run tests for Ignite | ||
| // Currently, we do local e2e tests only | ||
| // we have to wait until the CI setup to allow Ignite to run with sudo and in a KVM environment. |
There was a problem hiding this comment.
We can remove these comments now.
Devices are not namespaced in the Linux kernel. Device-node paths are not dependent on any particular path in a mount namespace. They are referred to globally by their major and minor number. This was only working before for devices that had the same path in-container as on-host. This patch creates a device-node in the sandbox container for the proper in-container specified path. Fixes weaveworks#646
stealthybox
force-pushed
the
ctrd-devpath-fix
branch
from
800fb6f
to
e8b05d8
Compare
|
🚢 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Devices are not namespaced in the Linux kernel.
Device-node paths are not dependent on any particular path in a mount namespace.
They are referred to globally by their major and minor number.
This was only working before for devices that had the same path in-container as on-host.
This patch creates a device-node in the sandbox container for the proper in-container specified path.
Fixes #646
I verified this makes volumes mount properly in vm's with containerd as the runtime.