Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

TODO Fix ignite stop --runtime=docker related CI test failure #658

Closed
stealthybox opened this issue Aug 10, 2020 · 4 comments
Closed

TODO Fix ignite stop --runtime=docker related CI test failure #658

stealthybox opened this issue Aug 10, 2020 · 4 comments
Labels
area/runtime Issues related to container runtimes area/testing Issues related to improving testing kind/bug Categorizes issue or PR as related to a bug.

Comments

@stealthybox
Copy link
Contributor

See the commented out TestVolumeWithDockerAndDockerBridge from #653 for the unrelated test failure.

@darkowlzz mentions that this test passes on his digital ocean machine.
One guess is that this failure is timing or race related.
We suppose that this could be resolved in the docker runtime client.
stealthybox added a commit to stealthybox/ignite that referenced this issue Aug 10, 2020
@stealthybox
Skip TestVolumeWithDockerAndDockerBridge weaveworks#658
800fb6f
stealthybox added a commit to stealthybox/ignite that referenced this issue Aug 10, 2020
@stealthybox
Skip TestVolumeWithDockerAndDockerBridge weaveworks#658
e8b05d8
@stealthybox stealthybox added area/runtime Issues related to container runtimes area/testing Issues related to improving testing kind/bug Categorizes issue or PR as related to a bug. labels Aug 10, 2020
@bboreham
Copy link
Contributor

Isn't this the same problem as in #679 ?

This was referenced Jan 15, 2021
Closed
Merged
@darkowlzz
Copy link
Contributor

Isn't this the same problem as in #679 ?

Yes, they are all docker related with the same container stop issue. The fix in #773 should solve this.
Great job on that 🥇

@jhult
Copy link
Contributor

jhult commented Oct 21, 2021

@darkowlzz, did #773 solve this?

@darkowlzz
Copy link
Contributor

did #773 solve this?

Yes, that solved the issue and since then we have been running TestVolumeWithDockerAndDockerBridge test without any issue.
Closing this issue. Feel free to ask any related questions if you have any. Thanks :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area/runtime Issues related to container runtimes area/testing Issues related to improving testing kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@darkowlzz @stealthybox @bboreham @jhult