Merge pull request facebookarchive#359 from kalessil/SCA

Static Code Analysis warnings fixed (partially)
wangjohnnywang · Feb 19, 2015 · 0413e1c · 0413e1c
2 parents ba3c9e5 + fe0624f
commit 0413e1c
Show file tree

Hide file tree

Showing 10 changed files with 32 additions and 31 deletions.
diff --git a/src/Facebook/Entities/AccessToken.php b/src/Facebook/Entities/AccessToken.php
@@ -154,11 +154,10 @@ public static function validateAccessToken(GraphSessionInfo $tokenInfo,
  $machineIdIsValid = $tokenInfo->getProperty('machine_id') == $machineId;
  $accessTokenIsValid = $tokenInfo->isValid();
 
+ $accessTokenIsStillAlive = true;
  // Not all access tokens return an expiration. E.g. an app access token.
  if ($tokenInfo->getExpiresAt() instanceof \DateTime) {
  $accessTokenIsStillAlive = $tokenInfo->getExpiresAt()->getTimestamp() >= time();
- } else {
- $accessTokenIsStillAlive = true;
  }
 
  return $appIdIsValid && $machineIdIsValid && $accessTokenIsValid && $accessTokenIsStillAlive;
@@ -374,7 +373,7 @@ public function __toString()
  */
  public function isAppSession()
  {
- return strpos($this->accessToken, "|") !== false;
+ return strpos($this->accessToken, '|') !== false;
  }
 
 }
diff --git a/src/Facebook/Entities/SignedRequest.php b/src/Facebook/Entities/SignedRequest.php
@@ -298,9 +298,10 @@ public static function hashSignature($encodedData, $appSecret = null)
  */
  public static function validateSignature($hashedSig, $sig)
  {
- if (mb_strlen($hashedSig) === mb_strlen($sig)) {
+ $intSignatureLength = mb_strlen($sig);
+ if (mb_strlen($hashedSig) === $intSignatureLength) {
  $validate = 0;
- for ($i = 0; $i < mb_strlen($sig); $i++) {
+ for ($i = 0; $i < $intSignatureLength; $i++) {
  $validate |= ord($hashedSig[$i]) ^ ord($sig[$i]);
  }
  if ($validate === 0) {

diff --git a/src/Facebook/FacebookRedirectLoginHelper.php b/src/Facebook/FacebookRedirectLoginHelper.php
@@ -90,7 +90,7 @@ public function __construct($redirectUrl, $appId = null, $appSecret = null)
  *
  * @return string
  */
- public function getLoginUrl($scope = array(), $version = null, $displayAsPopup = false, $authType = false)
+ public function getLoginUrl(array $scope = array(), $version = null, $displayAsPopup = false, $authType = false)
  {
  $version = ($version ?: FacebookRequest::GRAPH_API_VERSION);
  $this->state = $this->random(16);
@@ -124,7 +124,7 @@ public function getLoginUrl($scope = array(), $version = null, $displayAsPopup =
  *
  * @return string
  */
- public function getReRequestUrl($scope = array(), $version = null)
+ public function getReRequestUrl(array $scope = array(), $version = null)
  {
  $version = ($version ?: FacebookRequest::GRAPH_API_VERSION);
  $this->state = $this->random(16);
@@ -276,12 +276,12 @@ public function random($bytes)
  {
  if (!is_numeric($bytes)) {
  throw new FacebookSDKException(
- "random() expects an integer"
+ 'random() expects an integer'
  );
  }
  if ($bytes < 1) {
  throw new FacebookSDKException(
- "random() expects an integer greater than zero"
+ 'random() expects an integer greater than zero'
  );
  }
  $buf = '';

diff --git a/src/Facebook/FacebookRequest.php b/src/Facebook/FacebookRequest.php
@@ -199,13 +199,13 @@ public function __construct(
 
  $params = ($parameters ?: array());
  if ($session
- && !isset($params["access_token"])) {
- $params["access_token"] = $session->getToken();
+ && ! isset($params['access_token'])) {
+ $params['access_token'] = $session->getToken();
  }
- if (FacebookSession::useAppSecretProof()
- && !isset($params["appsecret_proof"])) {
- $params["appsecret_proof"] = $this->getAppSecretProof(
- $params["access_token"]
+ if (! isset($params['appsecret_proof'])
+ && FacebookSession::useAppSecretProof()) {
+ $params['appsecret_proof'] = $this->getAppSecretProof(
+ $params['access_token']
  );
  }
  $this->params = $params;
@@ -240,7 +240,7 @@ public function execute()
  $url = $this->getRequestURL();
  $params = $this->getParameters();
 
- if ($this->method === "GET") {
+ if ($this->method === 'GET') {
  $url = self::appendParamsToUrl($url, $params);
  $params = array();
  }
@@ -250,7 +250,7 @@ public function execute()
  $connection->addRequestHeader('Accept-Encoding', '*'); // Support all available encodings.
 
  // ETag
- if (isset($this->etag)) {
+ if (null !== $this->etag) {
  $connection->addRequestHeader('If-None-Match', $this->etag);
  }
 
@@ -260,7 +260,7 @@ public function execute()
 
  static::$requestCount++;
 
- $etagHit = 304 == $connection->getResponseHttpStatusCode();
+ $etagHit = 304 === $connection->getResponseHttpStatusCode();
 
  $headers = $connection->getResponseHeaders();
  $etagReceived = isset($headers['ETag']) ? $headers['ETag'] : null;
@@ -302,7 +302,7 @@ public function getAppSecretProof($token)
  *
  * @return string
  */
- public static function appendParamsToUrl($url, $params = array())
+ public static function appendParamsToUrl($url, array $params = array())
  {
  if (!$params) {
  return $url;

diff --git a/src/Facebook/FacebookRequestException.php b/src/Facebook/FacebookRequestException.php
@@ -80,7 +80,7 @@ public static function create($raw, $data, $statusCode)
  if (!isset($data['error']['code']) && isset($data['code'])) {
  $data = array('error' => $data);
  }
- $code = (isset($data['error']['code']) ? $data['error']['code'] : null);
+ $code = (isset($data['error']['code']) ? (int) $data['error']['code'] : null);
 
  if (isset($data['error']['error_subcode'])) {
  switch ($data['error']['error_subcode']) {
@@ -124,7 +124,7 @@ public static function create($raw, $data, $statusCode)
  }
 
  // Missing Permissions
- if ($code == 10 || ($code >= 200 && $code <= 299)) {
+ if ($code === 10 || ($code >= 200 && $code <= 299)) {
  return new FacebookPermissionException($raw, $data, $statusCode);
  }
 

diff --git a/src/Facebook/FacebookSignedRequestFromInputHelper.php b/src/Facebook/FacebookSignedRequestFromInputHelper.php
@@ -69,7 +69,7 @@ public function __construct($appId = null, $appSecret = null)
  /**
  * Instantiates a new SignedRequest entity.
  *
- * @param string|null
+ * @param string|null $rawSignedRequest
  */
  public function instantiateSignedRequest($rawSignedRequest = null)
  {
@@ -157,8 +157,9 @@ public function getRawSignedRequestFromPost()
  */
  public function getRawSignedRequestFromCookie()
  {
- if (isset($_COOKIE['fbsr_' . $this->appId])) {
- return $_COOKIE['fbsr_' . $this->appId];
+ $strCookieKey = 'fbsr_' . $this->appId;
+ if (isset($_COOKIE[$strCookieKey])) {
+ return $_COOKIE[$strCookieKey];
  }
  return null;
  }

diff --git a/src/Facebook/HttpClients/FacebookCurlHttpClient.php b/src/Facebook/HttpClients/FacebookCurlHttpClient.php
@@ -141,7 +141,7 @@ public function getResponseHttpStatusCode()
  *
  * @throws \Facebook\FacebookSDKException
  */
- public function send($url, $method = 'GET', $parameters = array())
+ public function send($url, $method = 'GET', array $parameters = array())
  {
  $this->openConnection($url, $method, $parameters);
  $this->tryToSendRequest();
@@ -167,7 +167,7 @@ public function send($url, $method = 'GET', $parameters = array())
  * @param string $method The request method
  * @param array $parameters The key value pairs to be sent in the body
  */
- public function openConnection($url, $method = 'GET', $parameters = array())
+ public function openConnection($url, $method = 'GET', array $parameters = array())
  {
  $options = array(
  CURLOPT_URL => $url,
@@ -180,14 +180,14 @@ public function openConnection($url, $method = 'GET', $parameters = array())
  CURLOPT_CAINFO => __DIR__ . '/certs/DigiCertHighAssuranceEVRootCA.pem',
  );
 
- if ($method !== "GET") {
+ if ($method !== 'GET') {
  $options[CURLOPT_POSTFIELDS] = $parameters;
  }
  if ($method === 'DELETE' || $method === 'PUT') {
  $options[CURLOPT_CUSTOMREQUEST] = $method;
  }
 
- if (!empty($this->requestHeaders)) {
+ if (count($this->requestHeaders) > 0) {
  $options[CURLOPT_HTTPHEADER] = $this->compileRequestHeaders();
  }
 

diff --git a/src/Facebook/HttpClients/FacebookGuzzleHttpClient.php b/src/Facebook/HttpClients/FacebookGuzzleHttpClient.php
@@ -101,7 +101,7 @@ public function getResponseHttpStatusCode()
  *
  * @throws \Facebook\FacebookSDKException
  */
- public function send($url, $method = 'GET', $parameters = array())
+ public function send($url, $method = 'GET', array $parameters = array())
  {
  $options = array();
  if ($parameters) {

diff --git a/src/Facebook/HttpClients/FacebookHttpable.php b/src/Facebook/HttpClients/FacebookHttpable.php
@@ -63,6 +63,6 @@ public function getResponseHttpStatusCode();
  *
  * @throws \Facebook\FacebookSDKException
  */
- public function send($url, $method = 'GET', $parameters = array());
+ public function send($url, $method = 'GET', array $parameters = array());
 
 }
diff --git a/src/Facebook/HttpClients/FacebookStreamHttpClient.php b/src/Facebook/HttpClients/FacebookStreamHttpClient.php
@@ -97,7 +97,7 @@ public function getResponseHttpStatusCode()
  *
  * @throws \Facebook\FacebookSDKException
  */
- public function send($url, $method = 'GET', $parameters = array())
+ public function send($url, $method = 'GET', array $parameters = array())
  {
  $options = array(
  'http' => array(