Static Code Analysis warnings fixed (partially) #359
Conversation
…onditionals, strict types, performance).
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| @@ -178,7 +177,7 @@ public static function getAccessTokenFromCode($code, $appId = null, $appSecret = | |||
| { | |||
| $params = array( | |||
| 'code' => $code, | |||
| 'redirect_uri' => '', | |||
There was a problem hiding this comment.
I'm 👎 for removing trailing commas from arrays. It doesn't cause any errors and is super convenient when adding new items. One of the nice features of PHP that JavaScript got wrong. :)
There was a problem hiding this comment.
And it's also a open door for copy paste =) I will revert this changes nevertheless.
|
👍 except for the things I commented on. :) |
|
@SammyK : reverted commas, null assignments, added spaces for casting and !isset. |
|
👍 |
Static Code Analysis warnings fixed (partially)
Code cleanup (actually code base is in very good state): code style, if conditionals, strict types, performance. Tests are green.
Following tools are used for code analysis: PhpStorm + Php Inspections (EA Extended).