This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
Add protoc-gen-go-grpc #2774
Merged
Add protoc-gen-go-grpc #2774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuessWhoSamFoo
force-pushed
the
issue-2691
branch
from
0ca2ccc
to
38ae03b
Compare
xtreme-vikram-yadav
approved these changes
Aug 19, 2021
|
I'm going to hold this until all other existing work with protobuf related changes are merged this sprint |
Signed-off-by: Sam Foo <[email protected]>
GuessWhoSamFoo
force-pushed
the
issue-2691
branch
from
38ae03b
to
8282672
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Per Readme in https://github.com/golang/protobuf, https://pkg.go.dev/mod/google.golang.org/protobuf is the preferred module which splits the protobuf compiler (protoc) and the runtime modules.
This update requires adding
mustEmbedUnimplemented__for each registered service. See grpc/grpc-go#3669 for background on this change.Which issue(s) this PR fixes