Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

Remove deprecated usage of pb.Timestamp #2691

Closed
GuessWhoSamFoo opened this issue Jul 27, 2021 · 0 comments · Fixed by #2774
Closed

Remove deprecated usage of pb.Timestamp #2691

GuessWhoSamFoo opened this issue Jul 27, 2021 · 0 comments · Fixed by #2774
Assignees
Labels
enhancement New feature or request plugin
Projects

Comments

@GuessWhoSamFoo
Copy link
Contributor

What steps did you take and what happened:
From github.com/golang/protobuf/ptypes,

// Timestamp converts a timestamppb.Timestamp to a time.Time.
// It returns an error if the argument is invalid.
//
// Unlike most Go functions, if Timestamp returns an error, the first return
// value is not the zero time.Time. Instead, it is the value obtained from the
// time.Unix function when passed the contents of the Timestamp, in the UTC
// locale. This may or may not be a meaningful time; many invalid Timestamps
// do map to valid time.Times.
//
// A nil Timestamp returns an error. The first return value in that case is
// undefined.
//
// Deprecated: Call the ts.AsTime and ts.CheckValid methods instead.

What did you expect to happen:
Remove usage before breaking changes.

Environment:

  • Octant version (use octant version): 0.22
@GuessWhoSamFoo GuessWhoSamFoo added enhancement New feature or request good first issue Good for newcomers plugin labels Jul 27, 2021
@wwitzel3 wwitzel3 added this to Incoming in Backlog via automation Jul 28, 2021
@wwitzel3 wwitzel3 moved this from Incoming to Product Excellence in Backlog Jul 28, 2021
@wwitzel3 wwitzel3 moved this from Product Excellence to Ecosystem in Backlog Jul 28, 2021
@wwitzel3 wwitzel3 removed this from Ecosystem in Backlog Aug 11, 2021
@wwitzel3 wwitzel3 added this to To do in 0.24 via automation Aug 11, 2021
@GuessWhoSamFoo GuessWhoSamFoo moved this from To do to Review in progress in 0.24 Aug 18, 2021
@GuessWhoSamFoo GuessWhoSamFoo self-assigned this Aug 18, 2021
@GuessWhoSamFoo GuessWhoSamFoo removed the good first issue Good for newcomers label Aug 18, 2021
0.24 automation moved this from Review in progress to Done Aug 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request plugin
Projects
No open projects
0.24
Done
Development

Successfully merging a pull request may close this issue.

1 participant