Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Segfault when running paranoid config in verbose mode #195

Merged
merged 1 commit into from
Aug 12, 2016

Conversation

jetwhiz
Copy link
Contributor

@jetwhiz jetwhiz commented Aug 12, 2016

When "external IV chaining" is enabled, cipherName_ parameter may be NULL, resulting in segfault in verbose log attempt

When "external IV chaining" is enabled, cipherName_ parameter may be
  NULL, resulting in segfault in verbose log attempt
@rfjakob
Copy link
Collaborator

rfjakob commented Aug 12, 2016

I'm sure the patch fixes the crash, but the actual bug is that cipherName_ is null, no?

@jetwhiz
Copy link
Contributor Author

jetwhiz commented Aug 12, 2016

@rfjakob -- from what I understand, it is normal for this to be possibly null for external IV chaining during a call to findOrCreate (create):

if (fsConfig->config->externalIVChaining) node->setName(0, 0, iv);

@rfjakob
Copy link
Collaborator

rfjakob commented Aug 12, 2016

I see. I think @vgough will agree that this is good to merge. Thanks!

@rfjakob rfjakob merged commit af0386d into vgough:master Aug 12, 2016
@jetwhiz jetwhiz deleted the fix-FileNode-setName branch February 2, 2019 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants