Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segfault when running paranoid config in verbose mode #192

Closed
jetwhiz opened this issue Aug 3, 2016 · 1 comment
Closed

Segfault when running paranoid config in verbose mode #192

jetwhiz opened this issue Aug 3, 2016 · 1 comment

Comments

@jetwhiz
Copy link
Contributor

jetwhiz commented Aug 3, 2016

The following logging line of code segfaults whenever cipherName_ is null (paranoid config -- external IV chaining):

https://github.com/vgough/encfs/blob/master/encfs/FileNode.cpp#L103

bool FileNode::setName(const char *plaintextName_, const char *cipherName_,
                       uint64_t iv, bool setIVFirst) {
  // Lock _lock( mutex );
VLOG(1) << "calling setIV on " << cipherName_;

Should be changed to:

  if (cipherName_)
    VLOG(1) << "calling setIV on " << cipherName_;
@jetwhiz
Copy link
Contributor Author

jetwhiz commented Aug 12, 2016

I've issued a pull request to fix this (#195)

@jetwhiz jetwhiz closed this as completed Aug 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant