New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule file for carma_msgs package ros1_bridge #153

Merged

msmcconnell merged 2 commits into foxy/develop from fix/add_mapping_for_system_alert_ros_bridge

Jan 10, 2022

Contributor

msmcconnell commented Jan 6, 2022 •

edited

Loading

PR Details

Description

Add missing rule.yml file for ros1_bridge to carma_msgs, so that /system_alert topic can be bridged

Related Issue

Supports: usdot-fhwa-stol/carma-platform#1557

Motivation and Context

Functional Hybrid ROS1 and ROS2 system

How Has This Been Tested?

local build testing and run testing

Types of changes

Defect fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that cause existing functionality to change)

Checklist:

I have added any new packages to the sonar-scanner.properties file
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
CARMA Contributing Guide
I have added tests to cover my changes.
All new and existing tests passed.


Add rule file for carma_msgs package ros1_bridge

ddffc89

msmcconnell requested a review from adev4a

January 6, 2022 22:34


Add export to carma_msgs package for ros1 ros2 mapping

7ed84ff

adev4a approved these changes

View reviewed changes

msmcconnell merged commit 2646e5b into foxy/develop

msmcconnell deleted the fix/add_mapping_for_system_alert_ros_bridge branch

January 10, 2022 13:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment