Wrap TwoViewMatchGeometricVerification::VerifyMatches #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Sorry for my late reply. Works for me! Could you please update the version in setup.py to 0.1.26 (line 68) I have not automated this. Then I would merge it to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrapped the
TwoViewMatchGeometricVerification::VerifyMatchesmethod. For what I was doing, it was more useful for it to returnstd::vector<IndexedFeatureMatch>as opposed tostd::vector<FeatureCorrespondence>, and you can build the correspondences from the indexed matches anyways since you have the features.The way I did it was a little hacky, i.e., making the
matches_attribute ofTwoViewMatchGeometricVerificationpublic, but I am open to other suggestions, e.g., making it return the indexed matches by default.