Wrap TwoViewMatchGeometricVerification::VerifyMatches #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrapped the
TwoViewMatchGeometricVerification::VerifyMatches
method. For what I was doing, it was more useful for it to returnstd::vector<IndexedFeatureMatch>
as opposed tostd::vector<FeatureCorrespondence>
, and you can build the correspondences from the indexed matches anyways since you have the features.The way I did it was a little hacky, i.e., making the
matches_
attribute ofTwoViewMatchGeometricVerification
public, but I am open to other suggestions, e.g., making it return the indexed matches by default.