chore: Fix lint #341
Merged
chore: Fix lint #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafilxTenfen
commented
Aug 8, 2022
•
RafilxTenfen
commented
- nolint now can not have whitespaces
- The new golint version requires go 1.19, So only at that workflow go 1.19 is going to be used
adamewozniak
approved these changes
Aug 9, 2022
facundomedica
added a commit
that referenced
this pull request
Aug 12, 2022
* update to go 1.18 * add #334 to changelog * update go 1.17 to 1.18 * mod tidy 1.18 * update go get to go install * fix linter * go mod tidy 1.17 * fixing unknown field 'Instances' in struct literal of type types.Info * add #341 to changelog * checking codecov Co-authored-by: Facundo Medica <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.