Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update to go 1.18 #334

Merged
merged 16 commits into from
Aug 12, 2022
Merged

chore: update to go 1.18 #334

merged 16 commits into from
Aug 12, 2022

Conversation

RafilxTenfen
Copy link

  • Moved from go 1.17 to 1.18

@RafilxTenfen RafilxTenfen self-assigned this Jul 27, 2022
@RafilxTenfen RafilxTenfen linked an issue Jul 27, 2022 that may be closed by this pull request
Go 1.18 #328
Closed
4 tasks
facundomedica
facundomedica suggested changes Aug 3, 2022
View reviewed changes
Copy link

@facundomedica facundomedica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to change the version in the workflows

@RafilxTenfen
Copy link
Author

We still need to change the version in the workflows

Good catch

@RafilxTenfen
Copy link
Author

We still need to change the version in the workflows

Done ^^
The only workflow that is not at go 1.18 is the linter that needs the 1.19

facundomedica
facundomedica approved these changes Aug 12, 2022
View reviewed changes
Copy link

@facundomedica facundomedica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lfg!

@facundomedica facundomedica merged commit eb07563 into main Aug 12, 2022
@facundomedica facundomedica deleted the rafilx/go1.18 branch August 12, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facundomedica facundomedica facundomedica approved these changes

Assignees

@RafilxTenfen RafilxTenfen

Labels
T:Dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Go 1.18
2 participants
@RafilxTenfen @facundomedica