Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add basic Diagrm components #8

Merged
merged 3 commits into from
Aug 2, 2024
Merged

add basic Diagrm components #8

merged 3 commits into from
Aug 2, 2024

Conversation

raylrui
Copy link
Contributor

@raylrui raylrui commented Jul 22, 2024 •
edited

diagram components

  1. add basic structure for each node, include nodes, edges
  2. add status variable for each node
  3. set styling for different status
  4. add workflow initial constants

example:
overview:
image

wgs:
image

wts:
image

Refactor components code about import format.

@raylrui raylrui self-assigned this Jul 22, 2024
@pdiakumis
Copy link
Member

That looks amazing:-)

@victorskl
Copy link
Member

React Flow, Pete.! :)

@raylrui raylrui force-pushed the feat/add-workflow-diagram-components branch from 725e539 to 59cf37d Compare August 1, 2024 03:35
@raylrui raylrui marked this pull request as ready for review August 1, 2024 07:26
@raylrui
Copy link
Contributor Author

raylrui commented Aug 1, 2024

Also combine the Refactor components code about " import" format.
Most components now has no default import except Layout components. @williamputraintan

williamputraintan
williamputraintan approved these changes Aug 1, 2024
View reviewed changes
Copy link
Member

@williamputraintan williamputraintan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good!

src/components/dialogs/SimpleDiag.tsx Outdated
@@ -0,0 +1,97 @@
import { FC } from 'react';
Copy link
Member

@williamputraintan williamputraintan Aug 1, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor typo in the filename

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, great thanks, merging

@raylrui raylrui merged commit 9ec6c9f into main Aug 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamputraintan williamputraintan williamputraintan approved these changes

Assignees

@raylrui raylrui

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@raylrui @pdiakumis @victorskl @williamputraintan