Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coupled model: IPD-CCPP b4b for coupled model, bugfix for stochastic physics #91

Merged

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Mar 24, 2020

This PR only updates .gitmodules and the submodule pointer for fv3atm for code review and testing.

Associated PRs:
NCAR/ccpp-physics#417
NOAA-EMC/fv3atm#86
#91

For regression testing, see below.

@climbfuji
Copy link
Collaborator Author

I ran rt.sh on hera.intel against the existing baseline, and all tests pass. Given that it is likely that we will make changes to fix the initialization of cice variables in IPD and CCPP, I will not upload the logs and wait for the changes to be finalized.

@climbfuji
Copy link
Collaborator Author

Regression tests all passed on hera.intel using rt.sh, regression test logs updated in the PR.

rt_hera_intel.log

@climbfuji
Copy link
Collaborator Author

climbfuji commented Mar 26, 2020

Regression tests passed on wcoss_dell_p3 using rt.sh and NEMSCompsetRun, regression test logs updated in the PR.

…FS_2017_coupled_satmedmf.xml to suite_FV3_GFS_2017_satmedmf_coupled.xml
…ogs for wcoss_cray using rt.sh and NEMSCompsetRun
@climbfuji
Copy link
Collaborator Author

Regression tests passed on wcoss_cray using rt.sh and NEMSCompsetRun, regression test logs updated in the PR.

@climbfuji
Copy link
Collaborator Author

Regression tests passed on hera.intel using NEMSCompsetRun - regression test logs updated in the PR. This completes the testing, ready to merge.

@climbfuji
Copy link
Collaborator Author

Ok, ufs-weather-model is ready as well.

@junwang-noaa junwang-noaa merged commit db103ca into ufs-community:develop Mar 27, 2020
christopherwharrop-noaa added a commit to christopherwharrop-noaa/ufs-weather-model that referenced this pull request Jun 29, 2021
…ure/RRFS_cloud_v2

Update parm files for RRFS cloud updates.
zach1221 pushed a commit that referenced this pull request Aug 22, 2023
…ng PR#1863) (#1844)

* Changes to logging and initialization of the CLM Lake Model.
* merge ccpp-physics #91 (UFS-SRW v3.0.0 SciDoc updates)

1. Use ice thickness hice(i) to find the level in the lake where ice is
   zero.
2. Do not allow lake temperature to be below freezing point if there is
   no ice.
3. If there is no snow or ice, do not allow surface lake temperature to
   be below freezing point.
   These changes fixed the problem with large errors in the energy budget
   at the beginning of the cold-start run with lakes.
4. Added flag to turn on debug print statements in the CLM lake model.

* explicitly turn of frac_ice for flake

* t_grnd(i) should be t_grnd(c)
-------------------------------------------------------------------
Co-authored-by: Samuel Trahan <[email protected]>
Co-authored-by: Grant Firl <[email protected]>
mkavulich pushed a commit to mkavulich/ufs-weather-model that referenced this pull request Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants