Changes to Logging and Initialization of the CLM Lake Model (Includi…

[JiliDong-NOAA]

…ng PR#1863) (ufs-community#1844)

• Changes to logging and initialization of the CLM Lake Model.
• merge ccpp-physics Coupled model: IPD-CCPP b4b for coupled model, bugfix for stochastic physics ufs-community/ufs-weather-model#91 (UFS-SRW v3.0.0 SciDoc updates)

1. Use ice thickness hice(i) to find the level in the lake where ice is zero.
2. Do not allow lake temperature to be below freezing point if there is no ice.
3. If there is no snow or ice, do not allow surface lake temperature to be below freezing point. These changes fixed the problem with large errors in the energy budget at the beginning of the cold-start run with lakes.
4. Added flag to turn on debug print statements in the CLM lake model.

• explicitly turn of frac_ice for flake

• t_grnd(i) should be t_grnd(c) -------------------------------------------------------------------
  Co-authored-by: Samuel Trahan [email protected]
  Co-authored-by: Grant Firl [email protected]

PR Author Checklist:

• I have linked PR's from all sub-components involved in section below.
• I am confirming reviews are completed in ALL sub-component PR's.
• I have run the full RT suite on either Hera/Cheyenne AND have attached the log to this PR below this line:
  • LOG:
• I have added the list of all failed regression tests to "Anticipated changes" section.
• I have filled out all sections of the template.

Description

Linked Issues and Pull Requests

Associated UFSWM Issue to close

Subcomponent Pull Requests

Blocking Dependencies

Subcomponents involved:

• AQM
• CDEPS
• CICE
• CMEPS
• CMakeModules
• FV3
• GOCART
• HYCOM
• MOM6
• NOAHMP
• WW3
• stochastic_physics
• none

Anticipated Changes

Input data

• No changes are expected to input data.
• Changes are expected to input data:
  • New input data.
  • Updated input data.

Regression Tests:

• No changes are expected to any regression test.
• Changes are expected to the following tests:

Tests effected by changes in this PR:

Libraries

• Not Needed
• Needed
  • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
  • Add issue link from JCSDA/spack-stack following this item

Code Managers Log

• This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
• Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.
  • N/A

Testing Log:

• RDHPCS
  • Hera
  • Orion
  • Jet
  • Gaea
  • Cheyenne
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
  • Completed
• opnReqTest
  • N/A
  • Log attached to comment