fix type mis-matches in nst water property module

[DeniseWorthen]

PR Author Checklist:

• I have linked PR's from all sub-components involved in section below.
• I am confirming reviews are completed in ALL sub-component PR's.
• I have run the full RT suite on either Hera/Cheyenne AND have attached the log to this PR below this line:
  • LOG: RegressionTests_hera.log
  • LOG: RegressionTests_hera.log
• I have added the list of all failed regression tests to "Anticipated changes" section.
• I have filled out all sections of the template.

Description

Updates one of the nst modules in CCPP to fix missing type-kind specifications and other variable type mis-matches.

Linked Issues and Pull Requests

Associated UFSWM Issue to close

• fixes fixing the missing type-kind specifications in one of the nst modules causes two regression tests to fail comparison #1980

Note original testing showed this was a non-B4B change for two wave model restarts, but re-testing this change shows it to be B4B for all cases.

Tests were re-run at 6b49fd5 and all tests passed.

Tests were re-run at 24e9207 after NST modules were modified to remove column 6 continuations and other changes and all tests passed.

Subcomponent Pull Requests

• fix missing or mis-matched variable types in nst_water_prop ccpp-physics#126
• fix type mis-matches in nst water property module NOAA-EMC/fv3atm#719

Blocking Dependencies

Subcomponents involved:

• AQM
• CDEPS
• CICE
• CMEPS
• CMakeModules
• FV3
• GOCART
• HYCOM
• MOM6
• NOAHMP
• WW3
• stochastic_physics
• none

Anticipated Changes

Input data

• No changes are expected to input data.
• Changes are expected to input data:
  • New input data.
  • Updated input data.

Regression Tests:

• No changes are expected to any regression test.
• Changes are expected to the following tests:

Tests effected by changes in this PR:

Libraries

• Not Needed
• Needed
  • Create separate issue in JCSDA/spack-stack asking for update to library. Include library name, library version.
  • Add issue link from JCSDA/spack-stack following this item

Code Managers Log

• This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR.
• Move new/updated input data on RDHPCS Hera and propagate input data changes to all supported systems.
  • N/A

Testing Log:

• RDHPCS
  • Hera
  • Orion
  • Hercules
  • Jet
  • Gaea
  • Cheyenne
• WCOSS2
  • Dogwood/Cactus
  • Acorn
• CI
  • Completed
• opnReqTest
  • N/A
  • Log attached to comment

[DeniseWorthen]

@BrianCurtis-NOAA Are we using "incomplete" when the only thing missing is reviews? Maybe we should have a different label for that case. To me, "incomplete" are issues that the maker of the PR should remedy (missing logs, dependent PRs and issues not listed etc). It's really up to CMs to review and approve the code and often the developer has no real control over that. Many developers don't even have the ability to assign a reviewer, for example.

[DeniseWorthen]

@BrianCurtis-NOAA As it turns out, I'm finding additional type-mismatches now that I've gone back and attempted to compile the nst modules from w/in CMEPS. So I'll need to make additional changes in my ccpp/physics PR.

[zach1221]

@DeniseWorthen I did some additional testing on Gaea C5 PR #1784 and everything passed. Can you combine the code changes from that PR into this one for us, please?

[epic-cicd-jenkins]

Jenkins-ci ORTs passed

[zach1221]

Ok done with testing. Let's begin the merge process, beginning with ccpp-physics #126 .

[zach1221]

@DeniseWorthen fv3atm is merged . New hash: NOAA-EMC/fv3atm@7eec3ce