Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ufs_public_release: updates from DTC and GSD, namelists for GFSv15.2 and GFSv16beta, update FMS submodule pointer #15

Conversation

climbfuji
Copy link
Collaborator

@climbfuji climbfuji commented Dec 10, 2019

This PR contains:

  • update FMS to point to tag 2019.01 of NOAA-GFDL
  • update of path to CCPP physics library for CCPP regression tests
  • add -Wall to compiler flags for GNU compilers
  • remove warnings for non-existent include directories for GNU compiler
  • update of regression testing scripts to detect errors in tests/run_test.sh
  • new regression tests fv3_ccpp_gfs_v15p2, fv3_ccpp_gfs_v15p2_debug, fv3_ccpp_gfs_v16beta, fv3_ccpp_gfs_v16beta_debug
  • update of rt.conf to run only those tests, update of RTPWD in rt.sh
  • make compile_cmake.sh work with Cheyenne Intel/GNU, and bugfixes for compile_cmake.sh

@climbfuji
Copy link
Collaborator Author

Associated PRs:
NOAA-PSL/stochastic_physics#7
NCAR/ccpp-framework#245
NCAR/ccpp-physics#369
NOAA-EMC/fv3atm#22
#15

For regression testing, see below.

@climbfuji climbfuji marked this pull request as ready for review December 10, 2019 22:33
@climbfuji
Copy link
Collaborator Author

Manual testing on macOS+GNU: code compiles and gives b4b identical results between IPD, CCPP dynamic and CCPP static in REPRO mode for fv3_gfdlmp / fv3_ccpp_gfdlmp.

@climbfuji
Copy link
Collaborator Author

climbfuji commented Dec 11, 2019

Follow-up commits to this PR will modify the regression test config rt.conf to only include two (new) tests on hera.intel, cheyenne.intel, cheyenne.gnu. Before making this switch, I ran the full set of regression tests (original rt.conf and NEMSCompsetRun) on hera.intel.

Original rt.conf: all tests pass except

  • fv3_gfdlmprad_noahmp (IPD) in PROD, DEBUG
  • fv3_ccpp_gfdlmprad_noahmp (CCPP) in PROD, DEBUG
  • fv3_ccpp_gsd (CCPP) in PROD, DEBUG

This is expected, because the updates to the GSD suite and the bugfix for the NoahMP precipitation rates are changing the answer.

rt_full.log
rt_132_fv3_ccpp_gsd_prod.log
rt_124_fv3_ccpp_gfdlmprad_noahmp_prod.log
rt_099_fv3_ccpp_gsd_repro.log
rt_091_fv3_ccpp_gfdlmprad_noahmp_repro.log
rt_051_fv3_gfdlmprad_noahmp_repro.log
rt_009_fv3_gfdlmprad_noahmp.log

NEMSCompsetRun: all tests pass except fv3_gfdlmprad_noahmp for the same reason as above.

NEMSCompsetRun.log

Update 2019/12/14: I reran the rt.conf tests after making the code changes (reducing the size of the commit as discussed with Jun and Arun) and after cleaning up the commit history. The result is the same, i.e. the same tests failed as described above. OK.

@climbfuji
Copy link
Collaborator Author

Regression testing using new rt.conf on Cheyenne with Intel GNU successful - first create new baseline, then rsync to final RTPWD, then test against RTPWD. Regression test logs have been updated in the repository.

rt_gnu_create.log
rt_gnu_verify.log
rt_intel_create.log
rt_intel_verify.log

(2) Add -Wall to compiler flags for GNU compilers
(3) Update ESMF version for modulefiles/gaea.intel/fv3.intel-16.0.3.210
(4) Change default queue to economy on Cheyenne, remove warnings for non-existent include directories for GNU compiler
…n_test.sh

(2) New regression tests fv3_ccpp_gfs_v15p2, fv3_ccpp_gfs_v15p2_debug, fv3_ccpp_gfs_v16beta, fv3_ccpp_gfs_v16beta_debug
(3) Update of rt.conf to run only those tests, update of RTPWD in rt.sh
(4) Bugfixes for regression testing system using new compile_cmake.sh, compile_cmake configuration for cheyenne.{intel,gnu}
@climbfuji climbfuji force-pushed the ufs_public_release_update_from_dtc_20191210 branch from b3d3950 to 8cabcd7 Compare December 13, 2019 17:09
@climbfuji
Copy link
Collaborator Author

@junwang-noaa @DusanJovic-NOAA @arunchawla-NOAA @ligiabernardet I fixed the .gitmodules typo that Dusan mentioned. I also updated the pull requests based on the conversation we had earlier this morning to minimize the changes in fv3atm and ufs-weather-model. I reran the regression tests for the two new tests and updated the regression test logs against the new baseline directory ufs-public-release-20191212 (on hera.intel, cheyenne.intel, cheyenne.gnu). I am also rerunning this against the previous baseline trunk-20191021 to make sure that the differences I get are the same than before the latest round of updates (i.e. only NoahMP and GSD physics) - just to make sure that everything is correct. Thanks for your patience!

@climbfuji climbfuji force-pushed the ufs_public_release_update_from_dtc_20191210 branch from 8cabcd7 to 1385c1e Compare December 13, 2019 20:54
@DusanJovic-NOAA
Copy link
Collaborator

Default ccpp suite in build.sh is set to FV3_GFS_2017_gfdlmp (CCPP_SUITES variable). SDF for FV3_GFS_2017_gfdlmp is removed from fv3atm/ccpp/suties. Which suite should be new default?

@climbfuji
Copy link
Collaborator Author

Only two to choose from! I would say GFSv15p2, but I would be ok with GFSv16beta as well. Jun, Arun?

@DusanJovic-NOAA DusanJovic-NOAA merged commit 7a4a7f3 into ufs-community:ufs_public_release Dec 17, 2019
@lisa-bengtsson lisa-bengtsson mentioned this pull request Apr 2, 2020
climbfuji referenced this pull request in climbfuji/ufs-weather-model Apr 18, 2020
XiaSun-Atmos pushed a commit to XiaSun-Atmos/ufs-weather-model that referenced this pull request Aug 8, 2020
…munity#27)

* add fh00 post control file, add restart output at specified forecast hours, ugwd bug fixes
* fv3atm ufs-community#15:Add support for GEFS-Aerosols restart capability
* remove comment prints
* fix RunDuration in atmos fcst side
* update post_gfs with new post changes
* comment out print line
* point fv3 dycore to the latest NOAA-EMC dev/emc branch
DeniseWorthen added a commit that referenced this pull request Aug 2, 2021
* Update InputsOutputs.rst, Codeoverview
* Stampede update (#15)
* Fix build env setup in Chapter 3 (#16)
* cleanup and reorg of 2.2 Directory Structure

Co-authored-by: BinLi-NOAA <[email protected]>
Co-authored-by: jiandewang <[email protected]>
Co-authored-by: Ali.Abdolali <[email protected]>
Co-authored-by: Ali Abdolali <[email protected]>
Co-authored-by: Jun Wang <[email protected]>
Co-authored-by: Minsuk Ji <[email protected]>
LarissaReames-NOAA pushed a commit to LarissaReames-NOAA/ufs-weather-model that referenced this pull request Oct 22, 2021
Merge GFDL new dynamic core 201912 release version to dev/emc.
epic-cicd-jenkins pushed a commit that referenced this pull request Apr 17, 2023
* Added build support on Odin and Stampede

* Updated Externals.cfg for Stampede/Odin updates
JessicaMeixner-NOAA pushed a commit to JessicaMeixner-NOAA/ufs-weather-model that referenced this pull request Oct 25, 2023
…update_150

Update ufs_acorn.intel.lua for spack-stack 1.5.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants