Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CICE6 to allow WW3-CICE6 coupling; add a cdeps test using C-grid for sea ice dynamics (was #1390) #1381

Merged
merged 21 commits into from
Aug 30, 2022

Conversation

DeniseWorthen
Copy link
Collaborator

@DeniseWorthen DeniseWorthen commented Aug 23, 2022

PR Checklist

  • This PR is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR. Please consult the ufs-weather-model wiki if you are unsure how to do this.

  • This PR has been tested using a branch which is up-to-date with the top of all sub-component repositories except for those sub-components which are the subject of this PR

  • An Issue describing the work contained in this PR has been created either in the subcomponent(s) or in the ufs-weather-model. The Issue should be created in the repository that is most relevant to the changes in contained in the PR. The Issue and the dependent sub-component PR
    are specified below.

  • Results for one or more of the regression tests change and the reasons for the changes are understood and explained below.

  • New or updated input data is required by this PR. If checked, please work with the code managers to update input data sets on all platforms.

Instructions: All subsequent sections of text should be filled in as appropriate.

The information provided below allows the code managers to understand the changes relevant to this PR, whether those changes are in the ufs-weather-model repository or in a subcomponent repository. Ufs-weather-model code managers will use the information provided to add any applicable labels, assign reviewers and place it in the Commit Queue. Once the PR is in the Commit Queue, it is the PR owner's responsibility to keep the PR up-to-date with the develop branch of ufs-weather-model.

Description

Adds the required field exchanges within the NUOPC cap to couple WW3 and CICE6. This allows eventual implementation of wave-ice coupling developed by CESM in UWM.

To test w/in UWM, additional changes are required:

  • the meshcap needs an update (meshcap update NOAA-EMC/WW3#757)

  • a new mesh cap switch file with IC4 needs to be added. Either the nml or inp file needs to specify ice parameters 1,5 as "C" and EF needs to be an output variable &OUTS E3D = 1, USSP = 1, IUSSP = 3, STK_WN = 0.04, 0.110, 0.3305 /

  • a new mod_def file with &SIC4 IC4METHOD = 8 needs to be created and added to the input directory

  • the following variables need to be added to ice_in

nfsd         = 12 (in grid_nml)
tr_fsd       = .true. (in tracer_nml)
wave_spec_type  = 'constant' (in forcing_nml)
  • the attribute wav_coupling_to_cice = true needs to be added to nems.configure (in ALLCOMP_attributes)

Issue(s) addressed

Testing

The additional files and settings described above were added to a sandbox on Cheyenne. The cpld_debug_noaero_p8 test was run for both Intel and GNU with mediator history files for ICE and WAV enabled. Both jobs ran to completion and the exchanged fields (Si_thick, Si_floediam, Sw_elevation_spectrum) appeared reasonable.

A 10d simulation using the cpld_control_noaero_p8 RT was also run, comparing the wave-ice solution against develop. The ice concentration and thickness changes are in-line w/ intuition that wave-ice interactions will impact marginal ice-zone thermodynamics, with enhanced breakup leading to increased lateral melt. Shown are ice concentration and thickness differences which arise from including wave-ice coupling.

waveiceNH

waveiceSH

Both Hera.Intel and Hera.GNU were run at 17f1605 and all tests except for cpld_control_ciceC_p8 reproduced. The change in the ciceC test is due to a change in the visc_method default to avg_zeta brought in with the update to Consortium/main. A test was run for this test retaining the visc_method as avg_strength and the develop-20220805 baseline for this test reproduced.

After adding the fix for the HAFS wav configurations 83edc46, the hafs_regional_atm_ocn_wav and hafs_regional_atm_wav tests will also change baseliens.

  • hera.intel
  • hera.gnu
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • acorn.intel
  • opnReqTest for newly added/changed feature
  • CI

Dependencies

@DeniseWorthen DeniseWorthen marked this pull request as ready for review August 24, 2022 12:50
@DeniseWorthen DeniseWorthen added the Baseline Updates Current baselines will be updated. label Aug 24, 2022
@github-actions
Copy link

@DeniseWorthen please bring these up to date with respective authoritative repositories

  • ufs-weather-model NOT up to date
  • mom6 NOT up to date

DeniseWorthen and others added 2 commits August 24, 2022 17:12
* turn ice coupling off for all hafs+wav tests
* turn current coupling off for hafs-atm-wav test
@DeniseWorthen DeniseWorthen changed the title Update CICE6 to allow WW3-CICE6 coupling Update CICE6 to allow WW3-CICE6 coupling; add a cdeps test using C-grid for sea ice dynamics (was #1390) Aug 29, 2022
@jkbk2004
Copy link
Collaborator

@DeniseWorthen @BrianCurtis-NOAA I will start creating new BL from hera.

@DeniseWorthen
Copy link
Collaborator Author

@jkbk2004 The BL date has not been updated.

@DeniseWorthen
Copy link
Collaborator Author

@jkbk2004 I don't think the jobs on hera had picked up yet before I removed the labels.

@jkbk2004
Copy link
Collaborator

@DeniseWorthen Thanks for catching it!

@BrianCurtis-NOAA
Copy link
Collaborator

Automated RT Failure Notification
Machine: jet
Compiler: intel
Job: BL
[BL] Repo location: /lfs4/HFIP/h-nems/emc.nemspara/autort/pr/1034797158/20220829214507/ufs-weather-model
[BL] Error: Test cpld_control_noaero_p8_agrid 007 failed in run_test failed
Please make changes and add the following label back: jet-intel-BL

@jkbk2004
Copy link
Collaborator

@DeniseWorthen all tests are done ok. We can move on to merge.

@DeniseWorthen
Copy link
Collaborator Author

Ready for approvals and merge.

Copy link
Collaborator

@BrianCurtis-NOAA BrianCurtis-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hash is good.

@jkbk2004 jkbk2004 merged commit 6ba0369 into ufs-community:develop Aug 30, 2022
NickSzapiro-NOAA added a commit to NickSzapiro-NOAA/ufs-weather-model that referenced this pull request Dec 12, 2023
Follows pdlib and ufs-community#1381, in particular.

For WW3, neither mod_def nor WW3/model/bin/switch_meshcap_pdlib_IC4 are here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hafs tests incorrectly set coupling fields for waves Add optional Wave-Ice Coupling to NUOPC cap
5 participants